Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zero-shot learning performance degradation after PTQ #3704

Merged

Conversation

sungchul2
Copy link
Contributor

@sungchul2 sungchul2 commented Jul 2, 2024

Summary

ticket no : 145764

Current benchmark dataset for zsl has a very small sample in trainset, so insufficient statistics for PTQ can be obtained.
By temporarily changing dataset from trainset to valset, more samples can be used during PTQ.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a proper fix, is it? Shouldn't we be raising an issue with the dataset?
@chuneuny-emily What do you think? We should consider either skipping small case for PTQ score comparisons or increasing the dataset.

@sungchul2 sungchul2 merged commit 7cdb154 into openvinotoolkit:releases/2.1.0 Jul 2, 2024
6 checks passed
@sungchul2 sungchul2 deleted the fix-zsl-ptq-perf-degrad branch July 2, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants