Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segmentation fault on VPM PTQ #3654

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

sungchul2
Copy link
Contributor

@sungchul2 sungchul2 commented Jun 21, 2024

Summary

ticket no. : 135462

After PTQ with num_workers > 0, sometimes segmentation fault error has occurred during releasing memory.
In recent performance benchmark test, it occurred and the test was failed even though PTQ was normally done.
https://github.com/openvinotoolkit/training_extensions/actions/runs/9608456874/job/26501287346#step:5:3091

To avoid this issue, temporarily force num_workers to 0 before PTQ.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@sungchul2 sungchul2 enabled auto-merge (squash) June 21, 2024 06:53
@sungchul2 sungchul2 merged commit 1f1039b into openvinotoolkit:develop Jun 21, 2024
13 checks passed
@sungchul2 sungchul2 deleted the fix-vpm-ptq-seg-fault branch June 21, 2024 08:52
@sungchul2 sungchul2 mentioned this pull request Jun 27, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants