Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exportable code dependency & fix a bug #3642

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

eunwoosh
Copy link
Contributor

@eunwoosh eunwoosh commented Jun 19, 2024

Summary

This PR includes

  • Align exportable code dependency to OTX
  • Fix a bug that value of type_of_model and converter_type are opposite

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added OTX 2.0 TEST Any changes in tests labels Jun 19, 2024
@eunwoosh eunwoosh enabled auto-merge (squash) June 20, 2024 04:24
Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, how about making the parameter used here a dataclass, it would be nice to declare it as a dataclass and manage it periodically.

@eunwoosh eunwoosh merged commit d4dbdeb into openvinotoolkit:develop Jun 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants