Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict configurable parameters to avoid unreasonable cost for SaaS trial #2891

Merged
merged 3 commits into from
Feb 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ learning_parameters:
time will be longer.
editable: true
header: Number of training iterations
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down Expand Up @@ -354,7 +354,7 @@ pot_parameters:
description: Number of data samples used for post-training optimization
editable: True
header: Number of data samples
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ learning_parameters:
time will be longer.
editable: true
header: Number of training iterations
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down Expand Up @@ -354,7 +354,7 @@ pot_parameters:
description: Number of data samples used for post-training optimization
editable: True
header: Number of data samples
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down
4 changes: 1 addition & 3 deletions src/otx/algorithms/anomaly/configs/base/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
# See the License for the specific language governing permissions
# and limitations under the License.

from sys import maxsize

from attr import attrs

from otx.algorithms.anomaly.configs.base.configuration_enums import (
Expand Down Expand Up @@ -97,7 +95,7 @@ class POTParameters(ParameterGroup):
description="Number of data samples used for post-training optimization",
default_value=300,
min_value=1,
max_value=maxsize,
max_value=1000,
)

@attrs
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ pot_parameters:
description: Number of data samples used for post-training optimization
editable: true
header: Number of data samples
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ pot_parameters:
description: Number of data samples used for post-training optimization
editable: true
header: Number of data samples
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ pot_parameters:
description: Number of data samples used for post-training optimization
editable: true
header: Number of data samples
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ pot_parameters:
description: Number of data samples used for post-training optimization
editable: true
header: Number of data samples
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ pot_parameters:
description: Number of data samples used for post-training optimization
editable: true
header: Number of data samples
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ pot_parameters:
description: Number of data samples used for post-training optimization
editable: true
header: Number of data samples
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ pot_parameters:
description: Number of data samples used for post-training optimization
editable: true
header: Number of data samples
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ pot_parameters:
description: Number of data samples used for post-training optimization
editable: true
header: Number of data samples
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ pot_parameters:
description: Number of data samples used for post-training optimization
editable: true
header: Number of data samples
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ learning_parameters:
time will be longer.
editable: true
header: Number of training iterations
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down Expand Up @@ -335,7 +335,7 @@ pot_parameters:
description: Number of data samples used for post-training optimization
editable: true
header: Number of data samples
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ hyper_parameters:
learning_rate_warmup_iters:
default_value: 50
num_iters:
default_value: 5000
default_value: 1000
enable_early_stopping:
default_value: false
use_adaptive_interval:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ hyper_parameters:
learning_rate_warmup_iters:
default_value: 50
num_iters:
default_value: 5000
default_value: 1000
enable_early_stopping:
default_value: false
use_adaptive_interval:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ hyper_parameters:
learning_rate_warmup_iters:
default_value: 50
num_iters:
default_value: 5000
default_value: 1000
enable_early_stopping:
default_value: false
use_adaptive_interval:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ hyper_parameters:
learning_rate_warmup_iters:
default_value: 50
num_iters:
default_value: 5000
default_value: 1000
enable_early_stopping:
default_value: false
use_adaptive_interval:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ hyper_parameters:
learning_rate_warmup_iters:
default_value: 50
num_iters:
default_value: 5000
default_value: 1000
enable_early_stopping:
default_value: false
use_adaptive_interval:
Expand Down
4 changes: 2 additions & 2 deletions src/otx/algorithms/common/configs/training_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ class BaseLearningParameters(ParameterGroup):
num_iters = configurable_integer(
default_value=1,
min_value=1,
max_value=100000,
max_value=1000,
header="Number of training iterations",
description="Increasing this value causes the results to be more robust but training time will be longer.",
affects_outcome_of=ModelLifecycle.TRAINING,
Expand Down Expand Up @@ -291,7 +291,7 @@ class BasePOTParameter(ParameterGroup):
description="Number of data samples used for post-training optimization",
default_value=300,
min_value=1,
max_value=100000,
max_value=1000,
)

stat_requests_number = configurable_integer(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ learning_parameters:
time will be longer.
editable: true
header: Number of training iterations
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down Expand Up @@ -454,7 +454,7 @@ pot_parameters:
description: Number of data samples used for post-training optimization
editable: True
header: Number of data samples
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ learning_parameters:
time will be longer.
editable: true
header: Number of training iterations
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down Expand Up @@ -439,7 +439,7 @@ pot_parameters:
description: Number of data samples used for post-training optimization
editable: True
header: Number of data samples
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ learning_parameters:
time will be longer.
editable: true
header: Number of training iterations
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down Expand Up @@ -424,7 +424,7 @@ pot_parameters:
description: Number of data samples used for post-training optimization
editable: True
header: Number of data samples
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
# and limitations under the License.


from sys import maxsize

from attr import attrs

from otx.algorithms.common.configs import (
Expand Down Expand Up @@ -102,7 +100,7 @@ class __POTParameter(BaseConfig.BasePOTParameter):
description="Number of data samples used for post-training optimization",
default_value=300,
min_value=1,
max_value=maxsize,
max_value=1000,
)

preset = selectable(
Expand Down
4 changes: 2 additions & 2 deletions src/otx/algorithms/segmentation/configs/configuration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ learning_parameters:
time will be longer.
editable: true
header: Number of training iterations
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down Expand Up @@ -391,7 +391,7 @@ pot_parameters:
description: Number of data samples used for post-training optimization
editable: True
header: Number of data samples
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ pot_parameters:
description: Number of data samples used for post-training optimization
editable: true
header: Number of data samples
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ pot_parameters:
description: Number of data samples used for post-training optimization
editable: true
header: Number of data samples
max_value: 100000
max_value: 1000
min_value: 1
type: INTEGER
ui_rules:
Expand Down
Loading