Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PTQ for visual prompting model #2519

Merged
merged 7 commits into from
Sep 27, 2023

Conversation

sungchul2
Copy link
Contributor

@sungchul2 sungchul2 commented Sep 26, 2023

Summary

This PR includes:

  • enable PTQ for visual prompting task
  • update opset version 12 -> 13
  • update unit / e2e tests
 mDice torch ov IR (fp32) ov IR (int8, only encoder) ov IR (int8, encoder + decoder)
0.9482 0.9471 0.9470 0.9423
throughput fp32 int8
encoder 0.85 fps 1.21 fps (+42%)
decoder 122.53 fps 141.78 fps (+16%)

How to test

$ tox -vv -e unittest-all-py310-pt1 -- tests/unit/algorithms/visual_prompting/tasks/test_openvino.py
============================================================= 11 passed, 12 warnings in 3.27s ==============================================================
Name                                                                                                                Stmts   Miss  Cover   Missing
-------------------------------------------------------------------------------------------------------------------------------------------------
src/otx/algorithms/visual_prompting/tasks/openvino.py                                                                 247     14    94%   275-277, 304-305, 309-310, 349, 412, 415, 435, 438, 452, 478

$ tox -vv -e tests-all-py310-pt1 -- tests/integration/cli/visual_prompting
=================================================== 8 passed, 2 skipped, 1 warning in 140.01s (0:02:20) ====================================================

$ tox -vv -e tests-all-py310-pt1 -- tests/e2e/cli/visual_prompting
======================================================== 10 passed, 2 warnings in 347.16s (0:05:47) ========================================================

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@sungchul2 sungchul2 requested a review from a team as a code owner September 26, 2023 05:07
@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests labels Sep 26, 2023
@sungchul2 sungchul2 requested a review from wonjuleee September 26, 2023 05:15
@sungchul2 sungchul2 enabled auto-merge (squash) September 27, 2023 00:47
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wonjuleee wonjuleee requested a review from harimkang September 27, 2023 01:58
Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

@sungchul2 sungchul2 merged commit 790b7cf into openvinotoolkit:develop Sep 27, 2023
@sungchul2 sungchul2 deleted the enable-vpm-ptq branch September 27, 2023 04:14
@sungchul2 sungchul2 added this to the 1.6.0 milestone Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants