Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model revamp for Geti - Object Detection #2485

Merged
merged 8 commits into from
Sep 8, 2023
Merged

Conversation

jaegukhyun
Copy link
Contributor

@jaegukhyun jaegukhyun commented Sep 7, 2023

Summary

Change experimental template to normal template for ResNeXt101-ATSS, YOLOX-S, YOLOX-L, YOLOX-X
E2E Tests on local env are passed

How to test

Unit, Intg, E2E

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added CLI Any changes in OTE CLI ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests DOC Improvements or additions to documentation labels Sep 7, 2023
@jaegukhyun jaegukhyun changed the title Jg/revamping detection Model revamp for Geti - Object Detection Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (1e7ef1b) 81.35% compared to head (bc543d1) 81.34%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2485      +/-   ##
===========================================
- Coverage    81.35%   81.34%   -0.01%     
===========================================
  Files          516      516              
  Lines        37686    37688       +2     
===========================================
- Hits         30660    30658       -2     
- Misses        7026     7030       +4     
Flag Coverage Δ
py310 81.34% <100.00%> (+<0.01%) ⬆️
py38 81.33% <100.00%> (-0.01%) ⬇️
py39 81.33% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/otx/cli/tools/find.py 86.66% <100.00%> (+0.22%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaegukhyun jaegukhyun marked this pull request as ready for review September 8, 2023 01:17
@jaegukhyun jaegukhyun requested a review from a team as a code owner September 8, 2023 01:17
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaegukhyun
Copy link
Contributor Author

@GalyaZalesskaya Could you check xai unit tests for new models?

@GalyaZalesskaya
Copy link
Contributor

@jaegukhyun Sure, I'll take a look today.

@jaegukhyun
Copy link
Contributor Author

@jaegukhyun Sure, I'll take a look today.

Thanks I'll merge this PR after you checking.

@jaegukhyun jaegukhyun merged commit 0413f46 into develop Sep 8, 2023
@jaegukhyun jaegukhyun deleted the jg/revamping-detection branch September 8, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation CLI Any changes in OTE CLI DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants