-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable configurable confidence threshold for ov export and inference #2388
Enable configurable confidence threshold for ov export and inference #2388
Conversation
59d899f
to
1039ce4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but there is a minor typo. Could you fix it?
This sentence is confusing. I think step 2 > (step 3 = step 5) is what you intended, is it right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, but could you review the review comments including mine?
Yeap that' right, I changed the comments. |
56b9e98
Summary
This PR includes enabling to control confidence threshold during eval(torch, ov models) and export.
From now on user can control confidence threshold via turning off result_based_threshold and setting confidence threshold through cli or configuration.yaml.
This is for #2291, a request for changing variables during evaluation and export procedure. Other variables such as input sizes and iou_threshold will be controlled after those variables can be controlled by configurable parameters.
How to test
You can see largely degraded performance in step 3 and results of step 3 and step 5 are same.
Checklist
License
Feel free to contact the maintainers if that's a concern.