Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SegmentMax-16 reference implementation #28788

Merged
merged 47 commits into from
Feb 17, 2025
Merged

Add SegmentMax-16 reference implementation #28788

merged 47 commits into from
Feb 17, 2025

Conversation

p-wysocki
Copy link
Contributor

@p-wysocki p-wysocki commented Feb 3, 2025 •
edited
Loading

@p-wysocki
WIP
d338b7e 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
WIP
462c43f 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
Cleanup
e3e44e2 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
Merge branch 'master' of https://github.com/openvinotoolkit/openvino …
adcce7d 
…into segmentmax_core

Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
Fix two tests
1affe5d 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
Merge Core PR
1246f0a 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
WIP
b3a13d3 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
CR WIP
094131d 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
WIP CR
f8c9919 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
WIP CR
f841c4c 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
WIP
3e882ed 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
Clenaup
7cef3b5 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
Merge Core PR
36e4bf6 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
WIP
85bb1e6 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
WIP
53c02aa 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
Add an edge case to tests
5ff3e4f 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
Cleanup
3415e83 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
Merge branch 'master' of https://github.com/openvinotoolkit/openvino …
fb76824 
…into segmentmax_core

Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
Apply CR
b8645d3 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
Merge upstream
da74ce4 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
Merge branch 'segmentmax_core' into segmentmax_ref
4aed4e9 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
Cleanup
2374c1b 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
Fix git
8c86ddf 
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki p-wysocki requested review from a team as code owners February 3, 2025 15:32
t-jankowski
t-jankowski approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@t-jankowski t-jankowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for src/core

@mlukasze
Copy link
Contributor

@mmikolajcz please review

github-merge-queue bot pushed a commit that referenced this pull request Feb 13, 2025
@p-wysocki @praasz @mitruska
Add SegmentMax-16 to Core (#28698)
d455dd2 
### Details:
 - Add `SegmentMax-16` to Core
 - Add shape inference function
 - Add tests
- A step towards enabling
https://www.tensorflow.org/api_docs/python/tf/math/segment_max and
https://www.tensorflow.org/api_docs/python/tf/raw_ops/SegmentMaxV2

### Related PRs:
 - #28103
 - #28788

### Tickets:
 - CVS-158916

---------

Signed-off-by: p-wysocki <[email protected]>
Co-authored-by: Pawel Raasz <[email protected]>
Co-authored-by: Katarzyna Mitrus <[email protected]>
@p-wysocki p-wysocki mentioned this pull request Feb 13, 2025
Open
@github-actions github-actions bot removed the category: CPU OpenVINO CPU plugin label Feb 14, 2025
@p-wysocki p-wysocki mentioned this pull request Feb 14, 2025
Open
@mitruska mitruska added this to the 2025.1 milestone Feb 17, 2025
@p-wysocki p-wysocki enabled auto-merge February 17, 2025 15:13
@p-wysocki p-wysocki added this pull request to the merge queue Feb 17, 2025
Merged via the queue into openvinotoolkit:master with commit 5de222d Feb 17, 2025
170 of 181 checks passed
@p-wysocki p-wysocki deleted the segmentmax_ref branch February 17, 2025 16:58
akladiev added a commit that referenced this pull request Feb 17, 2025
@akladiev
Revert "Add SegmentMax-16 reference implementation (#28788)"
4daca14 
This reverts commit 5de222d.
@akladiev akladiev mentioned this pull request Feb 17, 2025
Merged
akladiev added a commit that referenced this pull request Feb 17, 2025
@akladiev
Revert "Add SegmentMax-16 reference implementation" (#29037)
d7d43a0 
Reverts #28788
Merged by mistake in queue settings, there are
[failures](https://openvino-ci.toolbox.iotg.sclab.intel.com/job/private-ci/job/ie/job/build-windows-vs2022/6458/)
on Windows
@p-wysocki p-wysocki restored the segmentmax_ref branch February 18, 2025 10:06
@p-wysocki p-wysocki mentioned this pull request Feb 18, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 18, 2025
@p-wysocki @rkazants
@praasz @mitruska
Add SegmentMax-16 reference implementation (#29047)
18e97b6 
### Details:
- The original PR
(#28788) has been
mistakenly force-merged due to a mistake in merge queue settings. It was
later reverted, so this is the "new" Ref PR.
 - Add reference implementation
 - Add tests

### Related PRs:
 - #28103
 - #28698
 - #28979
 - #28999

### Tickets:
 - CVS-158917

---------

Signed-off-by: p-wysocki <[email protected]>
Co-authored-by: Roman Kazantsev <[email protected]>
Co-authored-by: Pawel Raasz <[email protected]>
Co-authored-by: Katarzyna Mitrus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitruska mitruska mitruska approved these changes

@t-jankowski t-jankowski t-jankowski approved these changes

@praasz praasz praasz approved these changes

@mmikolajcz mmikolajcz Awaiting requested review from mmikolajcz

@PiotrKrzem PiotrKrzem Awaiting requested review from PiotrKrzem

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: IE Tests OpenVINO Test: plugins and common category: TEMPLATE OpenVINO Template plugin
Projects
None yet
Milestone
2025.1
Development

Successfully merging this pull request may close these issues.
6 participants
@p-wysocki @mlukasze @mitruska @t-jankowski @praasz @rkazants