Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPU] Add support for i16, u16, and u32 element types in remote tensors #27573

Merged

Conversation

jade-cho
Copy link
Contributor

@jade-cho jade-cho commented Nov 15, 2024

Details:

  • Removed host memory data converting for user input/output tensors with data types i16, u16, or u32.
  • User tensors can now be directly used as plugin tensors without additional data conversion overhead.

Tickets:

  • 156709

@jade-cho jade-cho requested review from a team as code owners November 15, 2024 08:55
@github-actions github-actions bot added the category: GPU OpenVINO GPU plugin label Nov 15, 2024
+ Removed host memory data transformation for user input/output tensors with allocation type cl_mem and data types i16, u16, or u32.
+ User tensors can now be directly used as plugin tensors without additional data conversion overhead.
@jade-cho jade-cho force-pushed the remote_tensor_support_other_dtypes branch from a0a194b to f72547e Compare November 18, 2024 01:17
+ Do not add a reorder when user node is eltwise.
+ Because eltwise already supports i16, u16 and u32 data types.
+ Removes unnecessary code in add_required_reorders.
+ Changes the graph of the added func test.
@@ -30,7 +30,8 @@ static void CreateResultOp(ProgramBuilder& p, const std::shared_ptr<ov::op::v0::
auto out_format = cldnn::format::get_default_format(out_rank);

auto out_primitive_name = layer_type_name_ID(op);
auto out_data_type = cldnn::element_type_to_data_type(convert_to_supported_device_type(op->get_input_element_type(0)));
auto out_data_type = convert_to_supported_device_type(op->get_input_element_type(0));
out_data_type = out_data_type == ov::element::boolean ? ov::element::u8 : out_data_type;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can it be embedded into convert_to_supported_device_type?

Copy link
Contributor

@vladimir-paramuzov vladimir-paramuzov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall, LGTM now

@vladimir-paramuzov vladimir-paramuzov added this to the 2025.0 milestone Nov 19, 2024
@p-durandin p-durandin enabled auto-merge November 19, 2024 11:09
@p-durandin p-durandin added this pull request to the merge queue Nov 19, 2024
Merged via the queue into openvinotoolkit:master with commit ea36b83 Nov 19, 2024
154 checks passed
jade-cho added a commit to jade-cho/openvino that referenced this pull request Nov 21, 2024
…rs (openvinotoolkit#27573)

### Details:
- *Removed host memory data converting for user input/output tensors
with data types i16, u16, or u32.*
- *User tensors can now be directly used as plugin tensors without
additional data conversion overhead.*

### Tickets:
 - *156709*
NishantPrabhuFujitsu pushed a commit to NishantPrabhuFujitsu/openvino that referenced this pull request Nov 26, 2024
…rs (openvinotoolkit#27573)

### Details:
- *Removed host memory data converting for user input/output tensors
with data types i16, u16, or u32.*
- *User tensors can now be directly used as plugin tensors without
additional data conversion overhead.*

### Tickets:
 - *156709*
jade-cho added a commit to jade-cho/openvino that referenced this pull request Dec 4, 2024
jade-cho added a commit to jade-cho/openvino that referenced this pull request Dec 4, 2024
jade-cho added a commit to jade-cho/openvino that referenced this pull request Dec 4, 2024
jade-cho added a commit to jade-cho/openvino that referenced this pull request Dec 4, 2024
jade-cho added a commit to jade-cho/openvino that referenced this pull request Dec 5, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 6, 2024
### Details:
 - *Remove unecessary memory copy.*
 - *Tests already exists.*

### Tickets:
 - *158009*
peterchen-intel added a commit to peterchen-intel/openvino that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants