Returned OV 2024.3 references for OV 2024.5 in Weight Compression tests #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximProshin
approved these changes
Nov 7, 2024
alexsu52
reviewed
Nov 8, 2024
nikita-savelyevv
pushed a commit
to nikita-savelyevv/nncf
that referenced
this pull request
Dec 11, 2024
…ts (openvinotoolkit#3065) ### Changes Revert of openvinotoolkit#2954 Use [references for the OV 2024.3](https://github.com/ljaljushkin/nncf_pytorch/blob/873fbb80ab07bd41a3b1a2e21f68bc1a7a394810/tests/post_training/data/wc_reference_data.yaml) when run conformance tests with OV 2024.5. ### Reason for changes According to the CPU team: > 1) In 24.4 time frame, RMS impl has been enabled (openvinotoolkit/openvino#26147), which introduce some accuracy change due to vrsqrtss which is done by approximation. > 2) In 24.5 time frame, fix has been applied (openvinotoolkit/openvino#26817) to use vsqrtss instead. With that we can see the result can be covered to that prior to openvinotoolkit/openvino#26147 > With that (in 24.5), the accuracy result is recovered to that prior to RMS impl openvinotoolkit/openvino#26147. Let's say that 24.4 may has some accuracy issue in some case. 24.5 fix that issue. ### Related tickets 156605 156776 156237 151260 ### Tests - [x] 47 build of weekly/job/openvino-nightly/job/post_training_weight_compression  - [x] 48 build for xfail tests 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Revert of #2954
Use references for the OV 2024.3 when run conformance tests with OV 2024.5.
Reason for changes
According to the CPU team:
Related tickets
156605
156776
156237
151260
Tests