Little fix in function for recursive find sources #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiltsov-max
suggested changes
Jan 19, 2021
datumaro/components/extractor.py
Outdated
| @@ -624,10 +624,10 @@ def _find_sources_recursive(cls, path, ext, extractor_name, | |||
| for d in range(max_depth + 1): | |||
| sources.extend({'url': p, 'format': extractor_name} for p in | |||
| iglob(osp.join(path, *('*' * d), dirname, filename + ext))) | |||
| if callable(file_filter): | |||
There was a problem hiding this comment.
This way the function will be called on each iteration, and will re-check items from previous steps. We can move it out of the loop or include inside of extend(...).
zhiltsov-max
approved these changes
Jan 19, 2021
We can find the file at the initial iteration and exit the loop. Then it may not pass filtering and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_find_sources_recursiveHow to test
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.