Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added toxenv for snyk scanning #926

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Added toxenv for snyk scanning #926

merged 1 commit into from
Apr 11, 2023

Conversation

yunchu
Copy link
Contributor

@yunchu yunchu commented Apr 10, 2023

Summary

This one would be used to perform snyk code scanning from the internal development environment only because the API endpoint cannot be accessed from the external.

Once we setup the self-hosted CI instance, this one will be used by code-scanning workflow to automate snyk scanning & reporting. before that, this will be used to generate snyk report manually.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

it will be used to perform snyk code scanning
@yunchu yunchu requested review from a team as code owners April 10, 2023 08:34
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (606a0c8) 78.88% compared to head (fb0d638) 78.88%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #926   +/-   ##
========================================
  Coverage    78.88%   78.88%           
========================================
  Files          215      215           
  Lines        25220    25220           
  Branches      5046     5046           
========================================
  Hits         19895    19895           
  Misses        4191     4191           
  Partials      1134     1134           
Flag Coverage Δ
macos-11_Python-3.8 77.87% <ø> (ø)
ubuntu-20.04_Python-3.8 78.87% <ø> (ø)
windows-2019_Python-3.8 78.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yunchu yunchu merged commit 66c9422 into develop Apr 11, 2023
@vinnamkim vinnamkim deleted the infra/add-snyk-toxenv branch April 17, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants