Fix bug where custom environment plugins were lost on dataset merge #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes crash where before the names of the plugins were passed instead
This fixes a bug where the default environment was always returned on merge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1582 +/- ##
===========================================
+ Coverage 81.04% 81.06% +0.02%
===========================================
Files 278 278
Lines 32490 32490
Branches 6600 6599 -1
===========================================
+ Hits 26330 26339 +9
+ Misses 4706 4698 -8
+ Partials 1454 1453 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sooahleex
reviewed
Aug 14, 2024
sooahleex
approved these changes
Aug 20, 2024
sooahleex
added a commit
to sooahleex/datumaro
that referenced
this pull request
Aug 26, 2024
…penvinotoolkit#1582) I ran into an issue where plugins loaded into the `Environment` are not retained after merging. Turns out a generator is being passed to [Environment.merge](https://github.com/openvinotoolkit/datumaro/blob/30b1add52d6fe458dba5e32e1f63ffeea999ad7b/src/datumaro/components/environment.py#L271) instead of the expected Sequence. This meant that custom plugins were never registered into the merged environment. Reproducible example: ```python from datumaro.components.dataset import Dataset from datumaro.components.environment import Environment from datumaro.components.exporter import Exporter from datumaro.components.hl_ops import HLOps from datumaro.components.media import Image class MyPlugin(Exporter): pass environment = Environment() environment.exporters.register('my_plugin', MyPlugin) dataset1 = Dataset(media_type=Image, env=environment) datasets = [dataset1, dataset1.clone()] merged = HLOps.merge(*datasets) assert 'my_plugin' in dataset1.env.exporters # Passes assert 'my_plugin' in merged.env.exporters # Fails ``` --------- Co-authored-by: Sooah Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I ran into an issue where plugins loaded into the
Environmentare not retained after merging. Turns out a generator is being passed to Environment.merge instead of the expected Sequence. This meant that custom plugins were never registered into the merged environment.How to test
Reproducible example:
Checklist
License
Feel free to contact the maintainers if that's a concern.