Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling tfds import part to prevent cli error when installing datumaro with default option only #1454

Merged

Conversation

jihyeonyi
Copy link

@jihyeonyi jihyeonyi commented Apr 18, 2024

Summary

This is a bug fix for the issue #1444

How to test

  1. uninstall tfds if it exists.
  2. install datumaro with default option (pip install datumaro[default] or pip install -e .[default])
  3. run datum --version or datum --help

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@jihyeonyi jihyeonyi requested review from a team as code owners April 18, 2024 05:19
@jihyeonyi jihyeonyi requested review from itrushkin and removed request for a team April 18, 2024 05:19
@vinnamkim
Copy link
Contributor

@wonjuleee @yunchu
This hotfix should be released in 1.6.1 as fast as possible. Any system not installing tfds and installing Datumaro by pip install datumaro cannot execute every CLI command in 1.6.0.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (releases/1.6.0@6988d69). Click here to learn what that means.

Files Patch % Lines
src/datumaro/components/extractor_tfds.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             releases/1.6.0    #1454   +/-   ##
=================================================
  Coverage                  ?   80.66%           
=================================================
  Files                     ?      271           
  Lines                     ?    30722           
  Branches                  ?     6204           
=================================================
  Hits                      ?    24783           
  Misses                    ?     4538           
  Partials                  ?     1401           
Flag Coverage Δ
ubuntu-20.04_Python-3.10 80.64% <66.66%> (?)
windows-2022_Python-3.10 80.64% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jihyeonyi jihyeonyi changed the base branch from develop to releases/1.6.0 April 18, 2024 06:08
@jihyeonyi jihyeonyi force-pushed the jihyeony/fix_cli_error branch from 9372f41 to 6e763be Compare April 18, 2024 06:11
@jihyeonyi jihyeonyi force-pushed the jihyeony/fix_cli_error branch from 6e763be to 882645f Compare April 18, 2024 06:16
Copy link
Contributor

@yunchu yunchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jihyeonyi jihyeonyi merged commit 9f858b1 into openvinotoolkit:releases/1.6.0 Apr 18, 2024
8 checks passed
@wonjuleee wonjuleee added this to the 1.6.1 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants