Change image default dtype from float32 to uint8 #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kim, Vinnam <[email protected]>
vinnamkim
changed the title
Signed-off-by: Kim, Vinnam <[email protected]>
vinnamkim
merged commit 46a97d7
into
openvinotoolkit:releases/1.5.0
10 of 19 checks passed
yunchu
pushed a commit
to yunchu/datumaro
that referenced
this pull request
Oct 23, 2023
- Currently, there is discrepancy between the return image data types: `ImageFromBytes.data` (`np.float32`), `ImageFromNumpy.data` (`np.float32`), and `ImageFromFile.data` (`np.uint8`). - This makes the data loader based on the Arrow data format (using `ImageFromBytes.data`) slower since the image preprocessing will be conducted on the `np.float32` data (4x larger than `np.uint8`). - This PR forces `np.uint8` data to be returned for all `Image` classes. Signed-off-by: Kim, Vinnam <[email protected]>
6 tasks
vinnamkim
added a commit
that referenced
this pull request
Jan 23, 2024
) ### Summary - This is something missed in #1175 ### How to test I believe the existing tests (`tests/unit/test_images.py`) can cover it. ### Checklist <!-- Put an 'x' in all the boxes that apply --> - [ ] I have added unit tests to cover my changes. - [ ] I have added integration tests to cover my changes. - [ ] I have added the description of my changes into [CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md). - [ ] I have updated the [documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs) accordingly ### License - [ ] I submit _my code changes_ under the same [MIT License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. - [ ] I have updated the license header for each file (see an example below). ```python # Copyright (C) 2023 Intel Corporation # # SPDX-License-Identifier: MIT ``` --------- Signed-off-by: Kim, Vinnam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ImageFromBytes.data(np.float32),ImageFromNumpy.data(np.float32), andImageFromFile.data(np.uint8).ImageFromBytes.data) slower since the image preprocessing will be conducted on thenp.float32data (4x larger thannp.uint8).np.uint8data to be returned for allImageclasses.How to test
Our existing tests can cover this.
Checklist
License
Feel free to contact the maintainers if that's a concern.