Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new workflow for code scanning #940

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Conversation

yunchu
Copy link
Contributor

@yunchu yunchu commented Mar 2, 2023

Description

  • Provide a summary of the modification as well as the issue that has been resolved. List any dependencies that this modification necessitates.

  • Fixes # (issue)

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Would be for another PR, but I was wondering if we should we add bandit to pre-commit settings as well?

@yunchu
Copy link
Contributor Author

yunchu commented Mar 2, 2023

Thanks!

Would be for another PR, but I was wondering if we should we add bandit to pre-commit settings as well?

It's good to have but we need the report of the bandit scan as a file for some release process so I think it would be added to this workflow as an additional job.

@samet-akcay
Copy link
Contributor

Thanks!
Would be for another PR, but I was wondering if we should we add bandit to pre-commit settings as well?

It's good to have but we need the report of the bandit scan as a file for some release process so I think it would be added to this workflow as an additional job.

Yeah, that makes sense, thanks!

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch coverage: 94.73% and no project coverage change

Comparison is base (1407cfc) 86.77% compared to head (0d90d34) 86.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #940   +/-   ##
=======================================
  Coverage   86.77%   86.77%           
=======================================
  Files         165      165           
  Lines        6319     6322    +3     
=======================================
+ Hits         5483     5486    +3     
  Misses        836      836           
Impacted Files Coverage Δ
...ib/models/components/feature_extractors/torchfx.py 92.98% <94.73%> (+0.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samet-akcay samet-akcay merged commit 566e8cb into main Mar 2, 2023
@samet-akcay samet-akcay deleted the yunchule/enable-code-scan-wf branch March 2, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants