Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Patch requirements #892

Conversation

ashwinvaidya17
Copy link
Collaborator

Description

  • Move extra requirements to extras.txt
  • Check in each logger

@github-actions github-actions bot added CI Dependencies Pull requests that update a dependency file Logger Setup labels Feb 6, 2023
@github-actions github-actions bot added the Tests label Feb 6, 2023
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 86.85% // Head: 86.73% // Decreases project coverage by -0.13% ⚠️

Coverage data is based on head (6a8715e) compared to base (35a10f2).
Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files
@@                                Coverage Diff                                @@
##           refactor/sa/bump-up-pytorch-lightning-version     #892      +/-   ##
=================================================================================
- Coverage                                          86.85%   86.73%   -0.13%     
=================================================================================
  Files                                                165      165              
  Lines                                               6331     6318      -13     
=================================================================================
- Hits                                                5499     5480      -19     
- Misses                                               832      838       +6     
Impacted Files Coverage Δ
anomalib/data/btech.py 84.21% <ø> (-0.54%) ⬇️
anomalib/models/ganomaly/lightning_model.py 100.00% <ø> (ø)
anomalib/utils/callbacks/export.py 100.00% <ø> (ø)
anomalib/utils/callbacks/graph.py 40.00% <ø> (-7.06%) ⬇️
anomalib/utils/callbacks/metrics_configuration.py 100.00% <ø> (ø)
anomalib/utils/callbacks/min_max_normalization.py 91.11% <ø> (-0.38%) ⬇️
anomalib/utils/callbacks/model_loader.py 100.00% <ø> (ø)
...b/utils/callbacks/post_processing_configuration.py 100.00% <ø> (ø)
anomalib/utils/callbacks/tiler_configuration.py 50.00% <ø> (-4.55%) ⬇️
anomalib/utils/callbacks/timer.py 100.00% <ø> (ø)
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort

@samet-akcay samet-akcay merged commit 6386338 into refactor/sa/bump-up-pytorch-lightning-version Feb 6, 2023
@samet-akcay samet-akcay deleted the ashwin/patch_requirements branch February 6, 2023 16:56
samet-akcay added a commit that referenced this pull request Feb 7, 2023
* Modified padim configs

* Removed registry

* Replace LightningLoggerBase with Logger

* Remove resume_from_checkpoint arg from Trainer

* Updated cfa configs for v1.9.0

* Udate cflow configs to run on v1.9.0

* Udate csflow configs to run on v1.9.0

* Udate dfkde configs to run on v1.9.0

* Udate dfm configs to run on v1.9.0

* Udate draem configs to run on v1.9.0

* Udpdate fasatflow configs to run on v1.9.0

* Udpdate ganomaly configs to run on v1.9.0

* Udpdate patchcore configs to run on v1.9.0

* Udpdate reverse_distillation configs to run on v1.9.0

* Udpdate rkde configs to run on v1.9.0

* Udpdate stfpm configs to run on v1.9.0

* Update CHANGELOG.md

* Remove `inference_mode` from the configs to support PyTorch Lightning v1.6.*

* Update CHANGELOG.md

* Address pre-commit issues

* PL v1.6.* is not supported anymore

* Ignore no-member issue when getting trainer.callbacks

* Added requirements to pre-commit

* Resolve merge conflicts properly

* Revert the changes in tox.ini

* Address pre-commit errors

* Address pylint comments from pre-commit

* Address pylint comments from pre-commit. - This is the final one!!

* Fix tests. Tensorboard logger has not been addressed yet.

* 🩹 Patch requirements (#892)

* check extras dependencies in loggers

* Add recreate to workflow

* Revert -r flag

* Fix mocks

---------

Co-authored-by: Ashwin Vaidya <[email protected]>

* replace in-place torch operations in Denormalize

---------

Co-authored-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Dependencies Pull requests that update a dependency file Logger Setup Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants