Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD community project pipeline #757

Closed
wants to merge 3 commits into from
Closed

ADD community project pipeline #757

wants to merge 3 commits into from

Conversation

vnk8071
Copy link

@vnk8071 vnk8071 commented Dec 2, 2022

Description

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@github-actions github-actions bot added the Docs label Dec 2, 2022
@vnk8071 vnk8071 requested review from ashwinvaidya17 and removed request for djdameln December 2, 2022 11:04
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, fantastic work on the pipeline! Thanks for your efforts

Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vnk8071
Copy link
Author

vnk8071 commented Dec 2, 2022

@ashwinvaidya17 @djdameln This PR still can not pass some test check to merge request.. What should I do something more to merged this PR?

@ashwinvaidya17
Copy link
Collaborator

@vnk8071 Looks like the pre-commit checks have failed. Can you install pre-commit in your system as described here https://openvinotoolkit.github.io/anomalib/developer_guide/pre_commit_hooks.html. Then run pre-commit run --all and commit the modified files with the changes. Lemme know if something is not clear.

@vnk8071
Copy link
Author

vnk8071 commented Dec 5, 2022

@ashwinvaidya17 I have already follow your advise and commit modified. This is the first time I use pre-commit and face-off some problems to fix. Thank you so much.

@ashwinvaidya17
Copy link
Collaborator

There seems to be some unintentional files committed to this PR. I can see some .py files in the notebooks folder.

@vnk8071
Copy link
Author

vnk8071 commented Dec 6, 2022

I just run pre-commit follow your instruction and it make some change in notebook files. What should I do in this problem or you can add this to README.md and I will close the PRs?

@ashwinvaidya17
Copy link
Collaborator

@vnk8071 I've created a PR (#768) with the same changes. You can close this PR.

@vnk8071
Copy link
Author

vnk8071 commented Dec 7, 2022

@ashwinvaidya17 Thanks for your supported and I will close this PR.

@vnk8071 vnk8071 closed this Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pipeline training and inference Patchcore UI
3 participants