Fix #699

[jpcbertoldo]

• Fixes Wrong config reading in cflow? #699

Changes

• Bug fix (non-breaking change which fixes an issue)
• Refactor (non-breaking change which refactors the code base)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist

• [] My code follows the pre-commit style and check guidelines of this project.
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing tests pass locally with my changes

[ashwinvaidya17]

I think the updated config is not synced with github.

[samet-akcay]

I have the same comments

[jpcbertoldo]

I think the updated config is not synced with github.

I'm not sure what you mean but i changed what you said in the line comments.

[ashwinvaidya17]

Thanks

[ashwinvaidya17]

I think the updated config is not synced with github.

I'm not sure what you mean but i changed what you said in the line comments.

I meant maybe you made the changes locally but forgot to push them.

[samet-akcay]

Thanks

[jpcbertoldo]

The error is not the usual coverage upload but I'm not sure it is related to the PR.

[samet-akcay]

The error is not the usual coverage upload but I'm not sure it is related to the PR.

Based on the logs, looks like there is something wrong with this tests.
tests/pre_merge/utils/callbacks/normalization_callback/test_normalization_callback.py F [ 95%]

[jpcbertoldo]

The error is not the usual coverage upload but I'm not sure it is related to the PR.

Based on the logs, looks like there is something wrong with this tests. tests/pre_merge/utils/callbacks/normalization_callback/test_normalization_callback.py F [ 95%]

Thanks!
Will check it locally.

[jpcbertoldo]

pre_merge_pytest run-test: commands[0] | python -m pytest /cluster/CMM/home/jcasagrandebertoldo/repos/anomalib/tests/pre_merge/utils/callbacks/normalization_callback/test_normalization_callback.py --showlocals
==================================================================================== test session starts ====================================================================================
platform linux -- Python 3.8.13, pytest-7.2.0, pluggy-1.0.0
cachedir: .tox/pre_merge_pytest/.pytest_cache
rootdir: /cluster/CMM/home/jcasagrandebertoldo/repos/anomalib
plugins: flaky-3.7.0, anyio-3.6.2
collected 1 item                                                                                                                                                                            

tests/pre_merge/utils/callbacks/normalization_callback/test_normalization_callback.py .                                                                                               [100%]

======================================================================== 1 passed, 33 warnings in 123.98s (0:02:03) =========================================================================
__________________________________________________________________________________________ summary __________________________________________________________________________________________
  pre_merge_pytest: commands succeeded
  congratulations :)
 *  Terminal will be reused by tasks, press any key to close it. 

No problems in my local tox 🤔

[jpcbertoldo]

Maybe some flaky effect? Is there a way to relaunch it @samet-akcay ?

[samet-akcay]

Maybe some flaky effect? Is there a way to relaunch it @samet-akcay ?

Re-running the tests now...

[jpcbertoldo]

test_normalization_callback

Maybe some flaky effect? Is there a way to relaunch it @samet-akcay ?

Re-running the tests now...

Yeah, still.

I'm clueless here atm. I tried to search for "cflow" in the logs and there is nothing 🤔

Rebasing to see what happens.

[samet-akcay]

test_normalization_callback

Maybe some flaky effect? Is there a way to relaunch it @samet-akcay ?

Re-running the tests now...

Yeah, still.

I'm clueless here atm. I tried to search for "cflow" in the logs and there is nothing 🤔

Rebasing to see what happens.

Looks like there is something wrong with the tests. I'm observing a similar behaviour on another PR as well. Something seems to be broken.

[jpcbertoldo]

test_normalization_callback

Maybe some flaky effect? Is there a way to relaunch it @samet-akcay ?

Re-running the tests now...

Yeah, still.
I'm clueless here atm. I tried to search for "cflow" in the logs and there is nothing thinking
Rebasing to see what happens.

Looks like there is something wrong with the tests. I'm observing a similar behaviour on another PR as well. Something seems to be broken.

There are also some badly configured tests I could not pass locally but they pass in the CI apparently.
See #704.
But it's another test: tests/pre_merge/utils/callbacks/visualizer_callback/test_visualizer.py

[jpcbertoldo]

I think it's mergeable now?
The error now is the usual coverage report.

[samet-akcay]

I think it's mergeable now? The error now is the usual coverage report.

Yes, let's merge it! Thanks for the effort!