-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up the pytorch lightning to master branch due to vulnurability issues #55
Bump up the pytorch lightning to master branch due to vulnurability issues #55
Conversation
…o fix/sa/update-pytorch-lightning-to-master
…o fix/sa/update-pytorch-lightning-to-master
…m:openvinotoolkit/anomalib into fix/sa/update-pytorch-lightning-to-master
…o fix/sa/update-pytorch-lightning-to-master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the efforts and chasing all the issues due to the upgrade. Since this is not backward compatible, I would have proposed a major version bump up but I am concerned it might break things in OTE.
@ashwinvaidya17, maybe we could start thinking about having a master branch. What we could do is to merge other outstanding PRs to developmen first. We could then create a master branch. This PR could be finally merged to development. Once we ensure that OTE works with these changes, we could merge this to master as well. |
Description
anomalib
currently usespytorch-lightning
v1.3.6, which uses yaml unsafe loader, causing vulnurabilities. According to @LeonidBeynenson, this vulnurability has been addressed in the master branchv1.6.0dev
, but has not been released as a package yet. Therefore we usegit+https
inrequirements/base.txt
Known Issues
Changes
Checklist: