Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Bug Fix: Solve NaN values of anomaly scores for PatchCore model #549

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

bsl546
Copy link
Contributor

@bsl546 bsl546 commented Sep 9, 2022

Description

For images with large defects, the anomaly score of the patchcore method is sometimes nan in the actual version. This is due to the formula used to compute it, that involves torch.exp. To remedy this, one can replace the actual computation with a softmax that is more stable numerically and is able to deal with large values. This replacement is only correct and equivalent to the previous formula because the confidence tensor is of shape (1,N), N being the nearest neighbors.

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@samet-akcay samet-akcay requested a review from djdameln September 9, 2022 07:45
@samet-akcay samet-akcay changed the title Bug Fix: Solved nans values of anomaly score with patchcore model Bug Fix: Solve NaN values of anomaly scores for PatchCore model Sep 9, 2022
@samet-akcay samet-akcay changed the title Bug Fix: Solve NaN values of anomaly scores for PatchCore model 🐞 Bug Fix: Solve NaN values of anomaly scores for PatchCore model Sep 9, 2022
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samet-akcay
Copy link
Contributor

Thanks @bsl546, and welcome to the anomalib contributor community!

@samet-akcay samet-akcay merged commit 9c1c2cc into openvinotoolkit:main Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with patchcore anomaly score for large confidence scores
4 participants