-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/aupro test #444
Feature/aupro test #444
Conversation
We shouldn't regard other regions as FPs/TNs during per-region roc-construction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ORippler for adding this!
The test scripts do not seem to follow the code-quality standards, but it's ok for now. We don't check the tests at the moment, which we need to refactor quite soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this PR! I have a single concern regarding the license.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Description
Provide a summary of the modification as well as the issue that has been resolved. List any dependencies that this modification necessitates.
AUPRO
metric. While writing the tests, edge-cases were discovered and smaller bugs fixed.Fixes Add unit-tests for
AUPRO
metric #443Changes
Checklist
Remarks:
The reference implementation is taken from here, and currently unlicensed. The code itself is an adaptation of the official reference-code provided by MVTec.
If this prevents merging the PR, I would suggest removing the code and the corresponding tests from the unit-tests.