✨ Add hash check to data download #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samet-akcay
requested changes
Apr 26, 2022
anomalib/data/mvtec.py
Outdated
| @@ -384,6 +384,8 @@ def prepare_data(self) -> None: | |||
| filename=self.root / dataset_name, | |||
| reporthook=progress_bar.update_to, | |||
| ) | |||
| logger.info("Checking hash") | |||
| hash_check(self.root / dataset_name, "eefca59f2cede9c3fc5b6befbfec275e") | |||
There was a problem hiding this comment.
quite minor, but btech has zip_filename, would be good if the two has consistent implementation, (ie., both has zip_filename or path)
djdameln
requested changes
Apr 26, 2022
anomalib/data/utils/download.py
Outdated
| with open(file_path, "rb") as hash_file: | ||
| assert ( | ||
| hashlib.md5(hash_file.read()).hexdigest() == expected_hash | ||
| ), f"Downloaded file {file_path} does match the required hash." |
There was a problem hiding this comment.
this should be "does not match"
samet-akcay
approved these changes
Apr 29, 2022
samet-akcay
approved these changes
Apr 29, 2022
samet-akcay
approved these changes
Apr 29, 2022
djdameln
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check hash for files downloaded from remote location.
Fixes Check hash of downloaded MVTec and BTech datasets #253
Changes
Checklist