Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting: Enable PLR6301, # could be a function, class method or static method #2288

Merged
merged 10 commits into from
Sep 3, 2024

Conversation

samet-akcay
Copy link
Contributor

@samet-akcay samet-akcay commented Sep 2, 2024

πŸ“ Description

  • Enable PLR6301, # could be a function, class method or static method

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • πŸš€ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”’ Security update

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • πŸ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • πŸ“š I have made the necessary updates to the documentation (if applicable).
  • πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the efforts! I have a few questions.

What happens if instead of ignoring the rule, we convert methods like configure_transforms, on_train_start (and other lightning methods), forward, and backward to static?

tests/unit/engine/test_setup_transform.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 95.19231% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.91%. Comparing base (18ab25c) to head (8b26b57).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
src/anomalib/callbacks/nncf/utils.py 0.00% 4 Missing ⚠️
src/anomalib/models/video/ai_vad/regions.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2288      +/-   ##
==========================================
+ Coverage   80.85%   80.91%   +0.05%     
==========================================
  Files         247      247              
  Lines       10834    10886      +52     
==========================================
+ Hits         8760     8808      +48     
- Misses       2074     2078       +4     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the efforts! Let's merge this

@samet-akcay samet-akcay merged commit cdd338c into openvinotoolkit:main Sep 3, 2024
6 of 7 checks passed
@samet-akcay samet-akcay deleted the lint/enable-ruff-rules branch September 3, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants