Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes: Update callbacks to AnomalyModule #208

Merged
merged 3 commits into from
Apr 11, 2022
Merged

Minor fixes: Update callbacks to AnomalyModule #208

merged 3 commits into from
Apr 11, 2022

Conversation

ashwinvaidya17
Copy link
Collaborator

Description

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@ashwinvaidya17 ashwinvaidya17 changed the title WIP Update callbacks to AnomalyModule Minor fixes: Update callbacks to AnomalyModule Apr 8, 2022
@ashwinvaidya17 ashwinvaidya17 marked this pull request as ready for review April 8, 2022 07:00
@ashwinvaidya17 ashwinvaidya17 requested review from djdameln and samet-akcay and removed request for djdameln April 8, 2022 07:00
@ashwinvaidya17 ashwinvaidya17 merged commit c16d14c into development Apr 11, 2022
@ashwinvaidya17 ashwinvaidya17 deleted the refactor/av/anomalymodule_from_plmodule branch April 11, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djdameln djdameln djdameln approved these changes

@samet-akcay samet-akcay samet-akcay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: Modify all callbacks to return AnomalyModule instead of pl_module
3 participants
@ashwinvaidya17 @samet-akcay @djdameln