Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirements into pyproject.toml & Refactor anomalib install get_requirements #1808

Merged
merged 6 commits into from
Mar 18, 2024
Merged

Add requirements into pyproject.toml & Refactor anomalib install get_requirements #1808

merged 6 commits into from
Mar 18, 2024

Conversation

harimkang
Copy link
Contributor

@harimkang harimkang commented Mar 2, 2024

📝 Description

To fix pypi install not properly finding requirements inside packages, move the list of requirements to pyproject.toml so that it has the package's metadata, and modify it to use this metadata to gather information from anomalib install.

  • Move the list of requirements to pyproject.toml
  • Modify the way anomalib install to use package's metadata requirements

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

@harimkang harimkang marked this pull request as ready for review March 4, 2024 07:02
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'd also be in favour of removing all the requirements.txt files but if that's going to be a big PR we can do it later

@samet-akcay samet-akcay added this to the v1.0.1 milestone Mar 7, 2024
@samet-akcay samet-akcay merged commit 8c6e607 into openvinotoolkit:main Mar 18, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants