Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Fix broken 501 notebooks #1630

Merged

Conversation

adrianboguszewski
Copy link
Contributor

@adrianboguszewski adrianboguszewski commented Jan 12, 2024

πŸ“ Description

Changed metadata parameters. Also, I included more outputs for visualization purposes.

πŸ› οΈ Fixes #1489

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • πŸš€ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update

Copy link

Check out this pull request onΒ  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@adrianboguszewski adrianboguszewski marked this pull request as ready for review January 12, 2024 15:32
@adrianboguszewski
Copy link
Contributor Author

@samet-akcay ready :)

@samet-akcay
Copy link
Contributor

Thanks @adrianboguszewski. If that's alright, I'll choose the target branch v1?

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samet-akcay samet-akcay changed the base branch from main to v1 January 13, 2024 06:34
@samet-akcay samet-akcay changed the base branch from v1 to main January 13, 2024 06:34
@samet-akcay samet-akcay changed the title Fixed 501 notebooks 🐞 Fix broken 501 notebooks Jan 13, 2024
@samet-akcay samet-akcay merged commit 2e09314 into openvinotoolkit:main Jan 17, 2024
3 of 6 checks passed
@adrianboguszewski adrianboguszewski deleted the ov-notebooks-main branch January 22, 2024 12:08
ashwinvaidya17 pushed a commit to ashwinvaidya17/anomalib that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: OpenVINOInferencer.init() got an unexpected keyword argument 'metadata_path'
2 participants