Add modelAPI related stuff #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samet-akcay
reviewed
Jul 27, 2023
src/anomalib/deploy/export.py
Outdated
| tmp_xml_path = Path(Path(xml_file).parent) / "tmp.xml" | ||
| serialize(model, str(tmp_xml_path)) | ||
| tmp_xml_path.rename(xml_file) | ||
| Path(str(tmp_xml_path.parent / tmp_xml_path.stem) + ".bin").unlink() |
There was a problem hiding this comment.
can we have have something like this
Suggested change
| Path(str(tmp_xml_path.parent / tmp_xml_path.stem) + ".bin").unlink() | |
| tmp_xml_path.with_suffix(".bin").unlink() |
src/anomalib/deploy/export.py
Outdated
| Path(str(tmp_xml_path.parent / tmp_xml_path.stem) + ".bin").unlink() | ||
|
|
||
|
|
||
| def _serialize_list(arr): |
There was a problem hiding this comment.
would it be possible to annotate the variable and add docstring please
djdameln
reviewed
Jul 28, 2023
src/anomalib/deploy/export.py
Outdated
Comment on lines
224
to
227
| tmp_xml_path = Path(Path(xml_file).parent) / "tmp.xml" | ||
| serialize(model, str(tmp_xml_path)) | ||
| tmp_xml_path.rename(xml_file) | ||
| tmp_xml_path.with_suffix(".bin").unlink() |
There was a problem hiding this comment.
I think it would be good to add a comment explaining this section
added 2 commits
August 9, 2023 15:41
…n/mirror_model_api_changes
samet-akcay
reviewed
Aug 10, 2023
samet-akcay
requested changes
Aug 10, 2023
Co-authored-by: Samet Akcay <[email protected]>
djdameln
approved these changes
Aug 10, 2023
12 tasks
samet-akcay
approved these changes
Aug 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description