-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EfficientAD #1073
EfficientAD #1073
Conversation
src/anomalib/models/efficientad/pre_trained/teacher_medium_nelson1425.pth
Outdated
Show resolved
Hide resolved
I have trained a teacher model using albumentation transform and it's giving even better results than the previous model. I added the model weights and removed the old ones. Everything should be in place now and ready for merging. What about adding the model to tests etc.? |
@alexriedel1 very well done thank you for your work! Can you enter the Mvtec AD results in the tables in https://github.com/openvinotoolkit/anomalib/blob/main/README.md ? |
Hey, I dont have the ressources to run the anomalib implementation on all mvtec AD classes so I cannot add the results for this implementation of EfficientAD. If there is someone here who could do a benchmark (https://github.com/openvinotoolkit/anomalib/tree/main/tools/benchmarking) with EfficientAD that would be great |
I'll try to run a benchmark this week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the best action to take here? Should we keep them here or release them as assets in the releases section? @alexriedel1, @djdameln, @ashwinvaidya17 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main concern in that the git tree might become too big. I am in favour of releasing them as assets. We can add a readme with acknowledgement and license. Also, release will give us a permalink that we can refer to in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I will add the download function once the weights are released as assets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the link to the weights
https://github.com/openvinotoolkit/anomalib/releases/tag/efficientad_pretrained_weights
@alexriedel1, can you please double check if they work ok? Let me know if there is something wrong with the link. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright it's done! I have added support for the model weight download (and I also added support for arbitrary image sizes which was not the case before)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @alexriedel1. Looking good to me now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Im having a hard time getting the precommit hooks prettier and markdownlint to run on my windows machine |
We had this feedback from someone else too. Wasn't aware that pre-commit wasn't working well on a windows machine. Or maybe our configuration is problematic. We might need to investigate. Meanwhile I could run the checks on your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this contribution!
@alexriedel1 @samet-akcay
|
Description
Hey,
this is the work in progress for implementing EfficientAD based on the implementations https://github.com/nelson1425/EfficientAD/blob/main/efficientad.py and https://github.com/rximg/EfficientAD/tree/main
Right now the performance doesn't meet the paper results but I'm on it :)
Changes
Checklist