Normalize timezones in JSON output #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puerco
added
enhancement
This commit overrides the marshaling functions of the statement and vex.VEX object to normalize the timezones to Zulu and comply better with the in-toto guidelines (see https://github.com/in-toto/attestation/blob/main/docs/new_predicate_guidelines.md) Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
cpanato
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overrides the marshaling functions of the statement and vex.VEX object to normalize the timezones to Zulu and comply better with the in-toto predicate guidelines:
This is not a breaking change. It is just setting the timezones, no data loss or format changes are involved:
Format Before:
"timestamp": "2023-08-15T19:55:22.076684217-06:00"Format After: (not the same date, just to contrast the TZ)
"timestamp": "2023-12-05T05:06:38.099731287Z"Signed-off-by: Adolfo García Veytia (Puerco) [email protected]