Experimental ESP-IDF v4 #806
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llange
force-pushed
the
experimental-esp-idf-v4-rework-network
branch
from
28cb0b7 to
4954c69
Compare
This was referenced Feb 2, 2023
`wifi_interface_t` is more or less equivalent to `esp_interface_t` and the values are the same, however in terms of argument type it's more consistent to use `wifi_interface_t` for `esp_wifi_set_bandwidth()` and `esp_wifi_get_mac()` Signed-off-by: Ludovic LANGE <[email protected]>
…DF >= 4 Conditional compilation depending on the ESP-IDF version. Signed-off-by: Ludovic LANGE <[email protected]>
Signed-off-by: Ludovic LANGE <[email protected]>
Signed-off-by: Ludovic LANGE <[email protected]>
Signed-off-by: Ludovic LANGE <[email protected]>
Signed-off-by: Ludovic LANGE <[email protected]>
Signed-off-by: Ludovic LANGE <[email protected]>
Signed-off-by: Ludovic LANGE <[email protected]>
`xt_set_error_handler_callback` and `esp_task_wdt_get_trigger_tasknames` are related to crash handling and are only available in our ESP-IDF fork. We comment them before deciding what to do with it (either reimplement them in the new ESP-IDF framewok, or make use of the similar and new API `esp_core_dump_image_get` and `esp_core_dump_get_summary`). Signed-off-by: Ludovic LANGE <[email protected]>
Signed-off-by: Ludovic LANGE <[email protected]>
Signed-off-by: Ludovic LANGE <[email protected]>
Signed-off-by: Ludovic LANGE <[email protected]>
Signed-off-by: Ludovic LANGE <[email protected]>
Signed-off-by: Ludovic LANGE <[email protected]>
…(works in 3.3.x) Signed-off-by: Ludovic LANGE <[email protected]>
…tor" for ESP-IDF >= 4 (followup) Conditional compilation depending on the ESP-IDF version Signed-off-by: Ludovic LANGE <[email protected]>
Signed-off-by: Ludovic LANGE <[email protected]>
Signed-off-by: Ludovic LANGE <[email protected]>
Signed-off-by: Ludovic LANGE <[email protected]>
Signed-off-by: Ludovic LANGE <[email protected]>
Signed-off-by: Ludovic LANGE <[email protected]>
…Loop Signed-off-by: Ludovic LANGE <[email protected]>
Signed-off-by: Ludovic LANGE <[email protected]>
llange
force-pushed
the
experimental-esp-idf-v4-rework-network
branch
from
4954c69 to
af0475a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is more or less ready for review.
It aims to bring compatibility with ESP-IDFv4, with the following caveats:
xt_set_error_handler_callbackandesp_task_wdt_get_trigger_tasknames) is disabled for the moment, we need to decide whether we "fork" ESP-IDF again to port it ; or if the new APIs are enough to (partially ?) reimplement it (see commit: "WIP WIP WIP : comment out ESP-IDF specifics of our fork")OvmsConsole::Pollwhich I did not analyse (yet) and which I worked around by declaring a variable static (see commit: "WIP WIP WIP : prevent a crash at boot (to be analysed)")wolfsshandwolfsslin submodules (and move them one level below in terms of directories) - mainly to be able to have a CMakeLists.txt different from the upstream one. In the process, I "lost" one of our patches : 5144453 and we need to decide how to handle this.To be able to "test" this PR, you'll need:
v4.4.3git cherry-pick 273633ee310fbc18b17edfaeae3f3121508e3b8d(Which will bring the support for WHOLE_ARCHIVE: espressif/esp-idf@273633e )Ideally this may need to be broken down for better review - note that you should be able to review commit per commit as I tried to keep them consistent and compilable.