-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Popup] Define accessibility mappings for popup and its primitives #329
Comments
See many good/related comments on MicrosoftEdge/MSEdgeExplainers#434 |
There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label. |
So the explainer currently says this about accessibility mappings:
When this issue was opened, we were considering a new element, Can we a) confirm that the above paragraph is still completely correct, and b) talk in more detail about the correct behavior in the presence of the |
a) yes, the element that has the if there are any other accessibility semantics that the Regarding the trigger element, this is where the type of popup will be important. Because a default popup may need If a If it's an async popup, e.g., a toast notification popup - then we likely wouldn't want any mapping for the attribute as the live region announcement (or ideally exposed via a notification api - w3c/aria#832) of the popup's contents would be the audio cue of the popup... popping up. Please let me know if you have more questions / feel free to reach out and we can discuss these further if need be, especially if you are blocked on anything. |
Ok great, thanks for confirming. If there are conclusions that come out of w3c/aria#1697 for the popup itself, definitely @mention me so I can implement them.
Ok, to be sure I understood this correctly, for the trigger element:
Any mistakes there? |
re bullet 3 i would actually say at this point it's safe for something like a combobox with listbox popup, but just rubbish for buttons at this point. :( |
another thought that came to mind concerning the hint popup is how presently a e.g., A hint popup should probably also contribute to the name of the element if the element is otherwise not named. |
some additional accessibility related todos:
edit: co-authored by @aleventhal |
For a <button triggerpopup=foo> that points to a <div popup=hint id=foo> this CL will establish a described-by relationship for the button. This is as recommended in this issue/comment: openui/open-ui#329 (comment) AX-Relnotes: When using markup like <button triggerpopup=foo><div popup=hint id=foo>, an accessible description is now computed for the <button> from the content of the <div popup>. This is analogous to when the title attribute results in a description. In addition, in IA2/ATK, the object attribution "description-from" will be set to "popup-element". Bug: 1307772 Change-Id: If562b99af9b829841c038103c0c2dd447cba03d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648304 Commit-Queue: Mason Freed <[email protected]> Reviewed-by: Nasko Oskov <[email protected]> Reviewed-by: Nektarios Paisios <[email protected]> Reviewed-by: Aaron Leventhal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1005920}
Additional items that came out of meeting with @aleventhal @mfreed7 today regarding
|
"No accessible content" — would need a definition. |
More thoughts on a11y semantics for async popups:
F6 for navigation will be helpful. Another thing to consider is whether the Escape key can close it, as it could in a non-modal dialog. It doesn't seem like that's a possibility here, since we don't know if the author wants the user to be allowed to close it. |
this seems like a reasonable feature so long as the popup can receive focus / contains an element that can receive focus. i'm not sure if this is something that authors would always want, but so long as there is a way to override that would seem fine to me? also, maybe makes sense to have this rule apply to Regarding making |
Ok, per the resolution on 495 today, all of this great a11y discussion needs to be moved to the ARIA working group, to determine how to handle the popup attribute correctly. As such, I'd like to close this issue. So as to avoid losing the context from this discussion, please link back to this issue from the ARIA issue, once it's been opened. Thanks! |
This CL sets kExpandedExpanded and kExpandedCollapsed for any HTMLButtonElement that contains a popup triggering attribute (togglepopup, showpopup, or hidepopup), and for which the target element is a valid kPopup popup (i.e. not a popup=hint or popup=async). Note that per guidance [1] this CL does not set HasPopup::kMenu at all. [1] openui/open-ui#329 Bug: 1307772 Change-Id: I7a344e49cfc7667c379937d19a636e29804879b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3617148 Auto-Submit: Mason Freed <[email protected]> Reviewed-by: Aaron Leventhal <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1000811} NOKEYCHECK=True GitOrigin-RevId: 2e924a036dc1806ab62d2561abf6736e635469bc
For a <button triggerpopup=foo> that points to a <div popup=hint id=foo> this CL will establish a described-by relationship for the button. This is as recommended in this issue/comment: openui/open-ui#329 (comment) AX-Relnotes: When using markup like <button triggerpopup=foo><div popup=hint id=foo>, an accessible description is now computed for the <button> from the content of the <div popup>. This is analogous to when the title attribute results in a description. In addition, in IA2/ATK, the object attribution "description-from" will be set to "popup-element". Bug: 1307772 Change-Id: If562b99af9b829841c038103c0c2dd447cba03d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648304 Commit-Queue: Mason Freed <[email protected]> Reviewed-by: Nasko Oskov <[email protected]> Reviewed-by: Nektarios Paisios <[email protected]> Reviewed-by: Aaron Leventhal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1005920} NOKEYCHECK=True GitOrigin-RevId: c081b35f7169a5a23446ad455b884ef314dc9b17
Typically, when new primitives/elements are added to the platform, stakeholders of web plat accessibility will work with the editors of the HTML AAM to define accessibility mappings. This step should come a little later in the process when the design of said primitives is more formalized. Tracking this need here, as there has been express author interest in this.
In scope for this new mapping definition, currently:
popup
elementpopup
attributeanchor
attributedelegatesfocus
attributeinitiallyopen
attribute (refer to [Popup] Do we need the "open" content attribute? #311)The text was updated successfully, but these errors were encountered: