Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCT/TCP: Filtered out bridge devices. #9475

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

rakhmets
Copy link
Contributor

@rakhmets rakhmets commented Nov 7, 2023

What

Filtered out bridge devices.
Added control UCX_TCP_BRIDGE_ENABLE. The default value is set to no. It means that the function querying the list of available TCP devices doesn't include bridge devices to the list.

Why ?

The lane associated with the bridge device may be selected for transferring data. However, the lane is unreachable.

@rakhmets rakhmets force-pushed the topic/tcp-no-bridges branch from f0ae127 to b6e1145 Compare November 7, 2023 15:33
brminich
brminich previously approved these changes Nov 7, 2023
src/uct/tcp/tcp_md.c Outdated Show resolved Hide resolved
tvegas1
tvegas1 previously approved these changes Nov 7, 2023
src/uct/tcp/tcp_iface.c Outdated Show resolved Hide resolved
src/uct/tcp/tcp_md.c Outdated Show resolved Hide resolved
src/uct/tcp/tcp.h Outdated Show resolved Hide resolved
@rakhmets rakhmets dismissed stale reviews from tvegas1 and brminich via 4d5d882 November 10, 2023 11:05
Copy link
Contributor

@yosefe yosefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls squash

@rakhmets rakhmets force-pushed the topic/tcp-no-bridges branch from 4d5d882 to 9e5f37d Compare November 13, 2023 08:20
@rakhmets rakhmets enabled auto-merge November 13, 2023 09:47
@rakhmets rakhmets merged commit c5e7c3d into openucx:master Nov 13, 2023
114 checks passed
@rakhmets rakhmets deleted the topic/tcp-no-bridges branch December 12, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants