UCT/CUDA_IPC: fix peer-access-map init #6360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yosefe This fixes the issue brought up by @pentschev with #5815 |
|
Can one of the admins verify this patch? |
|
ok to test |
|
The performance issue is fixed with this PR, only errors such as those below should probably be demoted to debug/trace. |
|
On latest changes performance is still good, but I think log below was accidentally promoted to error in https://github.com/openucx/ucx/pull/6360/files#diff-561a7e4fa208245423bb161bc7a1cc05fbce0d65a10ef13c77e366f38c541826L308-R308 . Could you confirm this is accidental @Akshay-Venkatesh ? I now see those errors in my workflow: |
yosefe
reviewed
Feb 18, 2021
| @@ -305,7 +305,7 @@ UCS_PROFILE_FUNC(ucs_status_t, uct_cuda_ipc_map_memhandle, (key, mapped_addr), | |||
| } | |||
| } | |||
| } else { | |||
| ucs_debug("%s: failed to open ipc mem handle. addr:%p len:%lu", | |||
| ucs_error("%s: failed to open ipc mem handle. addr:%p len:%lu", | |||
There was a problem hiding this comment.
looks like log level was "swapped" ith line 114..
There was a problem hiding this comment.
Should be fixed now. cc @pentschev
pentschev
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
This PR addresses both issues I observed and LGTM now. Backporting #5815 along with this one to 1.10 is +1 from me now.
Thanks @Akshay-Venkatesh for fixing this so quickly!
Akshay-Venkatesh
force-pushed
the
topic/cuda-ipc-fix-peer-access-map-init
branch
from
da7c142 to
04e9f90
Compare
|
@yosefe is it ok to prepare a backport? |
Yes, let's have it along with the fix |
This was referenced May 21, 2021
rapids-bot bot
pushed a commit
to rapidsai/dask-cuda
that referenced
this pull request
May 21, 2021
The UCX-Py endpoint reuse is not anymore necessary, so we also disable that for UCX 1.11+. The primary reason it was introduced was to circumvent an issue with CUDA IPC that was resolved by openucx/ucx#6360. Using the endpoint reuse class has also proven to be very slow, taking a long time to initialize for clusters with just a few dozen workers and pretty much unusable for a cluster in the order of 100 workers. Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Benjamin Zaitlen (https://github.com/quasiben) URL: #620
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Peer-accessibility map is a 2-d matrix and it was incorrectly initialized following restructuring. This PR fixes that.