Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUDA/TEST: Check if libcudart_static is present for memory hook test #6089

Merged

Conversation

yosefe
Copy link
Contributor

@yosefe yosefe commented Jan 4, 2021

Why

Fix build failure when only dynamic libraries of Cuda are installed

@yosefe yosefe force-pushed the topic/cuda-test-check-if-libcudart-static-is branch from 25db04a to f5a3ef5 Compare January 4, 2021 23:16
@yosefe yosefe force-pushed the topic/cuda-test-check-if-libcudart-static-is branch from f5a3ef5 to 8024093 Compare January 5, 2021 09:41
Allows passing Cuda -L<path> flag to static build example, without
passing -lcudart.
@yosefe
Copy link
Contributor Author

yosefe commented Jan 6, 2021

@bureddy , can you pls look again? i added few fixes, also a separation of CUDA_LIBS from CUDA_LDFLAGS, in case user passed custom Cuda path (./configure --with-cuda=<path>) - need to pass CUDA_LDFLAGS to the example link command, but not CUDA_LIBS (since they are dynamic)

@yosefe yosefe merged commit 0d1ca83 into openucx:master Jan 6, 2021
@yosefe yosefe deleted the topic/cuda-test-check-if-libcudart-static-is branch January 6, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants