Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHM/POSIX: code beautify #5637

Merged
merged 1 commit into from
Sep 1, 2020
Merged

SHM/POSIX: code beautify #5637

merged 1 commit into from
Sep 1, 2020

Conversation

hoopoepg
Copy link
Contributor

  • removed datatype spec from cb init

SHM/POSIX: code beautify
8a3d10a 
- removed datatype spec from cb init
@hoopoepg
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

yosefe
yosefe reviewed Sep 1, 2020
View reviewed changes
src/uct/sm/mm/posix/mm_posix.c
.mkey_pack = uct_posix_md_mkey_pack,
.is_sockaddr_accessible = (uct_md_is_sockaddr_accessible_func_t)ucs_empty_function_return_zero,
.detect_memory_type = (uct_md_detect_memory_type_func_t)ucs_empty_function_return_unsupported
.is_sockaddr_accessible = ucs_empty_function_return_zero_int,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't use ucs_empty_function_return_zero here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_sockaddr_accessible is signed int (...), but ucs_empty_function_return_zero returns unsigned integer and compiler prompts warning

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@hoopoepg
Copy link
Contributor Author

hoopoepg commented Sep 1, 2020

@yosefe ok to merge?

@yosefe yosefe merged commit 9050b1a into openucx:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosefe yosefe yosefe left review comments

@brminich brminich brminich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoopoepg @yosefe @brminich