AZP/JUCX: publish SNAPHOT and RELEASE jars to maven central. #4591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petro-rudenko
force-pushed
the
jucx/publish-snapshot-to-maven
branch
from
f99a8a9
to
07d86c4
Compare
Mellanox CI: UNKNOWN on 25 workers (click for details)Note: the logs will be deleted after 24-Dec-2019
|
Mellanox CI: UNKNOWN on 25 workers (click for details)Note: the logs will be deleted after 24-Dec-2019
|
petro-rudenko
force-pushed
the
jucx/publish-snapshot-to-maven
branch
2 times, most recently
from
0038325
to
437649b
Compare
Mellanox CI: UNKNOWN on 25 workers (click for details)Note: the logs will be deleted after 24-Dec-2019
|
petro-rudenko
force-pushed
the
jucx/publish-snapshot-to-maven
branch
from
437649b
to
66d5da4
Compare
Mellanox CI: UNKNOWN on 25 workers (click for details)Note: the logs will be deleted after 24-Dec-2019
|
Mellanox CI: UNKNOWN on 25 workers (click for details)Note: the logs will be deleted after 24-Dec-2019
|
petro-rudenko
force-pushed
the
jucx/publish-snapshot-to-maven
branch
from
66d5da4
to
5da7954
Compare
Mellanox CI: FAILED on 4 of 25 workers (click for details)Note: the logs will be deleted after 25-Dec-2019
|
|
@shamisp following on f2f talk, do you think we should publish JUCX in maven central, given that the Java API will probably change? |
|
If we publish, It is out there and we would have to support backward
compatible version if we change it a future. My understanding it is like
upstream to distro.
…On Fri, Dec 20, 2019 at 11:51 Yossi Itigin ***@***.***> wrote:
@shamisp <https://github.com/shamisp> following on f2f talk, do you think
we should publish JUCX in maven central, given that the Java API will
probably change?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4591?email_source=notifications&email_token=AARB5WGCDYUKNHJN4FLDKATQZUHZPA5CNFSM4J3ZWTXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHN2KJA#issuecomment-568042788>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARB5WEDYLBAPNFKR6SCOB3QZUHZPANCNFSM4J3ZWTXA>
.
|
@petro-rudenko WDYT? |
|
|
Seems like snapshot is a sensible way to provide an early access to
something like this.
Release - if we modify the API, my understanding that user would have to
update their code, to compile the code with never version, other it will
break. Based on Yossi’s come that we already know that API will change, I
would think we are not at the release stage yet ?
…On Fri, Dec 20, 2019 at 14:45 Peter Rudenko ***@***.***> wrote:
1. So there's 2 publishing: SNAPSHOT and RELEASE. Snapshot is
published on every master update. Snapshot can be overridden.
2. It'll include jucx.so into jar, so each jar published would have
it's own jucx.so (for now only for 1 cpu x platform).
3. When someone uses JUCX from maven - he'll specify concrete version.
E.g. 1.8.0 - so he'll get exact version + jucx native binary.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4591?email_source=notifications&email_token=AARB5WGMTWWR7AJ2ZVIDUYTQZU4JJA5CNFSM4J3ZWTXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHOIFGY#issuecomment-568099483>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARB5WGVWWGKUWEACQENXODQZU4JJANCNFSM4J3ZWTXA>
.
|
|
The release of JUCX should be also automatically when there would be 1.8 release of UCX. Release is immutable, so if would need to make a bugfixes - need to release, say 1.8.1 version - the same as ucx. |
|
So, in the user code they specify the version of UCX the code uses and
based on this it will not try to bring new major release ?
Is there realization on the user side that in order to pull newer features
they would have update their codes ?
…On Fri, Dec 20, 2019 at 15:16 Peter Rudenko ***@***.***> wrote:
The release of JUCX should be also automatically when there would be 1.8
release of UCX. Release is immutable, so if would need to make a bugfixes -
need to release, say 1.8.1 version - the same as ucx.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4591?email_source=notifications&email_token=AARB5WBK7P6PUCYKGMQ7BV3QZU733A5CNFSM4J3ZWTXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHOKG7Y#issuecomment-568107903>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARB5WGB4JZO6SWMOB5X2PTQZU733ANCNFSM4J3ZWTXA>
.
|
|
@petro-rudenko did we ever publish a release, or just snapshot? |
petro-rudenko
force-pushed
the
jucx/publish-snapshot-to-maven
branch
2 times, most recently
from
e5201f4
to
7160b4e
Compare
Mellanox CI: FAILED on 13 of 25 workers (click for details)Note: the logs will be deleted after 17-Jan-2020
|
Mellanox CI: PASSED on 25 workers (click for details)Note: the logs will be deleted after 17-Jan-2020
|
petro-rudenko
force-pushed
the
jucx/publish-snapshot-to-maven
branch
from
7160b4e
to
aaa24c1
Compare
Mellanox CI: FAILED on 2 of 25 workers (click for details)Note: the logs will be deleted after 20-Jan-2020
|
petro-rudenko
force-pushed
the
jucx/publish-snapshot-to-maven
branch
from
aaa24c1
to
f8cccc9
Compare
Mellanox CI: FAILED on 2 of 25 workers (click for details)Note: the logs will be deleted after 21-Jan-2020
|
petro-rudenko
force-pushed
the
jucx/publish-snapshot-to-maven
branch
from
f8cccc9
to
16aae18
Compare
|
Also:
|
petro-rudenko
force-pushed
the
jucx/publish-snapshot-to-maven
branch
from
16aae18
to
d0828f8
Compare
Mellanox CI: UNKNOWN on 25 workers (click for details)Note: the logs will be deleted after 13-Feb-2020
|
petro-rudenko
force-pushed
the
jucx/publish-snapshot-to-maven
branch
3 times, most recently
from
9919166
to
bfafc98
Compare
|
Ok so publishing now from fedora original container. Ready to review. |
Mellanox CI: UNKNOWN on 5 workers (click for details)Note: the logs will be deleted after 13-Feb-2020
|
Mellanox CI: UNKNOWN on 21 workers (click for details)Note: the logs will be deleted after 13-Feb-2020
|
Mellanox CI: UNKNOWN on 17 workers (click for details)Note: the logs will be deleted after 13-Feb-2020
|
|
rnat |
Mellanox CI: FAILED on 4 of 25 workers (click for details)Note: the logs will be deleted after 13-Feb-2020
|
Mellanox CI: FAILED on 4 of 25 workers (click for details)Note: the logs will be deleted after 13-Feb-2020
|
yosefe
reviewed
Feb 6, 2020
Comment on lines
+215
to
+218
| <compilerArgs> | ||
| <arg>-h</arg> | ||
| <arg>${native.dir}</arg> | ||
| </compilerArgs> |
There was a problem hiding this comment.
To remove
10:12:23 [WARNING]
10:12:23 [WARNING] Some problems were encountered while building the effective model for org.openucx:jucx:jar:1.8.0
10:12:23 [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.apache.maven.plugins:maven-compiler-plugin @ line 328, column 15
bfafc98
to
1643f26
Compare
Mellanox CI: FAILED on 2 of 25 workers (click for details)Note: the logs will be deleted after 13-Feb-2020
|
Mellanox CI: FAILED on 4 of 25 workers (click for details)Note: the logs will be deleted after 14-Feb-2020
|
petro-rudenko
force-pushed
the
jucx/publish-snapshot-to-maven
branch
from
1643f26
to
587c927
Compare
petro-rudenko
force-pushed
the
jucx/publish-snapshot-to-maven
branch
from
587c927
to
a0c8931
Compare
Mellanox CI: ABORTED on 25 workers (click for details)Note: the logs will be deleted after 14-Feb-2020
|
Mellanox CI: FAILED on 3 of 25 workers (click for details)Note: the logs will be deleted after 14-Feb-2020
|
|
hpc-test-node2 issue with ens2f0 |
Mellanox CI: FAILED on 3 of 25 workers (click for details)Note: the logs will be deleted after 14-Feb-2020
|
|
bot:mlx:retest |
Mellanox CI: FAILED on 2 of 25 workers (click for details)Note: the logs will be deleted after 15-Feb-2020
|
|
issue is #4752 |
Mellanox CI: PASSED on 25 workers (click for details)Note: the logs will be deleted after 16-Feb-2020
|
amaslenn
approved these changes
Feb 9, 2020
yosefe
approved these changes
Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Set the default version to SNAPHOT. Publish Snapshot and Release from AZP. Remove libjucx dependencies from other ucx libs. TODO: cross-compile for other platforms/cpu and include all binaries to jar.
Why ?
To have nightly snapshots artifacts on maven central + to automate jar release procedure.