DOC/CONVENTIONS: Cleanup Conventions and Notations section of the API document #4531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
shamisp
approved these changes
Dec 2, 2019
|
ok to test |
|
@bbenton title check failed. See #2 https://github.com/openucx/ucx/wiki/Guidance-for-contributors |
Mellanox CI: PASSED on 25 workers (click for details)Note: the logs will be deleted after 10-Dec-2019
|
Mellanox CI: PASSED on 25 workers (click for details)Note: the logs will be deleted after 10-Dec-2019
|
bbenton
changed the title
|
@yosefe ? |
|
@bbenton pls fix commit title |
bbenton
force-pushed
the
topic/doc-fix-to-conventions
branch
from
ecb9552 to
5d2068e
Compare
yosefe
approved these changes
Dec 4, 2019
|
failure is unrelated, since it's just a doc change - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Describe what this PR is doing.
Fix heading for Signal Handler Functions section to display properly
Grammar fix: "an UCX" -> "a UCX"
Why ?
Justification for the PR. If there is existing issue/bug please reference. For
bug fixes why and what can be merged in a single item.
Documentation Cleanup
How ?
It is optional but for complex PRs please provide information about the design,
architecture, approach, etc.