UCT/CONFIG: Use configuration parsing infrastructure in UCT. #32

yosefe · 2014-11-25T18:03:22Z

No description provided.

mellanox-github · 2014-11-25T18:07:51Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com:8000/jenkins-secure/job/gh-ucx-pr/55/

Build Log
last 50 lines

[...truncated 2176 lines...]
[       OK ] test_class.create_destroy (0 ms)
[ RUN      ] test_class.failure
[       OK ] test_class.failure (0 ms)
[----------] 3 tests from test_class (1 ms total)

[----------] 1 test from test_uct_perf
[ RUN      ] test_uct_perf.envelope
[     INFO ] rc_mlx5/mlx5_0:1     put latency : 2.149 usec
/scrap/jenkins/jobs/gh-ucx-pr/workspace/contrib/../test/gtest/uct/test_uct_perf.cc:302: Failure
Expected: (value) < (test->max), actual: 2.149234412448787 vs 1
[     INFO ] rc_mlx5/mlx5_0:1     put msgrate : 12.111 Mpps
[  FAILED  ] test_uct_perf.envelope (1111 ms)
[----------] 1 test from test_uct_perf (1111 ms total)

[----------] 3 tests from test_uct
[ RUN      ] test_uct.query_resources
[     INFO ] 0: rc_mlx5 on mlx5_0:1 at 6502.32 MB/sec
[       OK ] test_uct.query_resources (13 ms)
[ RUN      ] test_uct.open_iface
[       OK ] test_uct.open_iface (30 ms)
[ RUN      ] test_uct.connect_ep
[       OK ] test_uct.connect_ep (170 ms)
[----------] 3 tests from test_uct (213 ms total)

[----------] Global test environment tear-down
[==========] 71 tests from 20 test cases ran. (5463 ms total)
[  PASSED  ] 70 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] test_uct_perf.envelope

 1 FAILED TEST
make: *** [test] Error 1
make: Leaving directory `/scrap/jenkins/jobs/gh-ucx-pr/workspace/build-test/test/gtest'
Build step 'Execute shell' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: **/*.tap
Did not find any matching files.
[Valgrind] Files to copy:
[Valgrind] Analysing valgrind results
[Valgrind] Ending the valgrind analysis.
Anchor chain: could not read file with links: /var/lib/jenkins/jobs/gh-ucx-pr/workspace/jenkins_sidelinks.txt (No such file or directory)
[copy-to-slave] The build is taking place on the master node, no copy back to the master will take place.
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Request made to compress build log
Sending email to: [email protected] [email protected] [email protected]
[BFA] Scanning build for known causes...

[BFA] Done. 0s

Test FAILed.

mike-dubman · 2014-11-26T09:03:48Z

retest this please

mellanox-github · 2014-11-26T09:06:44Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com:8000/jenkins-secure/job/gh-ucx-pr/59/

Build Log
last 50 lines

[...truncated 2180 lines...]
[       OK ] test_class.failure (0 ms)
[----------] 3 tests from test_class (0 ms total)

[----------] 1 test from test_uct_perf
[ RUN      ] test_uct_perf.envelope
[     INFO ] rc_mlx5/mlx5_0:1     put latency : 1.427 usec
/scrap/jenkins/jobs/gh-ucx-pr/workspace/contrib/../test/gtest/uct/test_uct_perf.cc:302: Failure
Expected: (value) < (test->max), actual: 1.4267020980955816 vs 1
[     INFO ] rc_mlx5/mlx5_0:1     put msgrate : 1.108 Mpps
/scrap/jenkins/jobs/gh-ucx-pr/workspace/contrib/../test/gtest/uct/test_uct_perf.cc:301: Failure
Expected: (value) >= (test->min), actual: 1.1084298972691249 vs 6
[  FAILED  ] test_uct_perf.envelope (4146 ms)
[----------] 1 test from test_uct_perf (4146 ms total)

[----------] 3 tests from test_uct
[ RUN      ] test_uct.query_resources
[     INFO ] 0: rc_mlx5 on mlx5_0:1 at 6502.32 MB/sec
[       OK ] test_uct.query_resources (13 ms)
[ RUN      ] test_uct.open_iface
[       OK ] test_uct.open_iface (30 ms)
[ RUN      ] test_uct.connect_ep
[       OK ] test_uct.connect_ep (167 ms)
[----------] 3 tests from test_uct (210 ms total)

[----------] Global test environment tear-down
[==========] 71 tests from 20 test cases ran. (8432 ms total)
[  PASSED  ] 70 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] test_uct_perf.envelope

 1 FAILED TEST
make: *** [test] Error 1
make: Leaving directory `/scrap/jenkins/jobs/gh-ucx-pr/workspace/build-test/test/gtest'
Build step 'Execute shell' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: **/*.tap
Did not find any matching files.
[Valgrind] Files to copy:
[Valgrind] Analysing valgrind results
[Valgrind] Ending the valgrind analysis.
Anchor chain: could not read file with links: /var/lib/jenkins/jobs/gh-ucx-pr/workspace/jenkins_sidelinks.txt (No such file or directory)
[copy-to-slave] The build is taking place on the master node, no copy back to the master will take place.
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Request made to compress build log
Sending email to: [email protected] [email protected] [email protected]
[BFA] Scanning build for known causes...

[BFA] Done. 0s

Test FAILed.

mike-dubman · 2014-11-26T09:11:38Z

src/uct/tl/tl.c

+
+
+ucs_config_field_t uct_iface_config_table[] = {
+  {"MAX_SHORT", "128",


SHORT can be a misleading name as it conflicts with primitive type name.
lets rename it to MAX_SMALL?

the intention was to use the same name, because it imposes the size limit for this primitive type.

lets discuss it on the dev call.
Maybe we should use tiny/small/medium/large/xl/xxl terminology to not overlap with lang primitive times.

mike-dubman · 2014-11-26T10:36:22Z

i think you need to rebase to use latest jenkins script and make it pass.

* Configuration will be per-interface. It's not scalable to have one per-endpoint, and looks like we can avoid per-context configuration. * User would have to create configuration object by calling uct_iface_config_read(), possibly modifying it later. Then, pass it to uct_iface_open(). * Define a hierarchy of iface configurations for: tl, ib, rc, rm_mlx5. * Add max_short and max_bcopy configurations to tl. * Add ucx_info utility to print default configuration.

yosefe · 2014-11-26T11:03:06Z

rebased

yosefe · 2014-11-26T11:05:09Z

retest this please

mellanox-github · 2014-11-26T11:07:42Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com:8000/jenkins-secure/job/gh-ucx-pr/62/
Test PASSed.

mike-dubman · 2014-11-26T11:20:23Z

👍

UCT/CONFIG: Use configuration parsing infrastructure in UCT.

TEST/APPS/IO_DEMO: Add option specify differen port for each server

Create function_test.sh for automatic function test

Event notif+collection

mike-dubman reviewed Nov 26, 2014
View reviewed changes

yosefe added 3 commits November 26, 2014 12:54

TEST: Don't enforce performance values on SandyBridge CPU

c1e48ec

JENKINS: Add ucx_info tool to jenkins

e869013

yosefe force-pushed the topic/uct-config branch from 7833499 to e869013 Compare November 26, 2014 11:01

mike-dubman added a commit that referenced this pull request Nov 26, 2014

Merge pull request #32 from yosefe/topic/uct-config

4a8e8b6

UCT/CONFIG: Use configuration parsing infrastructure in UCT.

mike-dubman merged commit 4a8e8b6 into openucx:master Nov 26, 2014

mike-dubman deleted the topic/uct-config branch November 26, 2014 11:20

amaslenn pushed a commit to amaslenn/ucx that referenced this pull request Jun 2, 2020

CI: check steps generator openucx#32

1e8b4ab

alinask pushed a commit to alinask/ucx that referenced this pull request Sep 13, 2020

Merge pull request openucx#32 from leibin2014/integration3

f32d95f

TEST/APPS/IO_DEMO: Add option specify differen port for each server

shizhibao pushed a commit to shizhibao/ucx that referenced this pull request Jan 16, 2021

Merge pull request openucx#32 from benbenmumu/huawei

04bc807

Create function_test.sh for automatic function test

dmitrygx pushed a commit to dmitrygx/ucx that referenced this pull request Dec 1, 2021

Merge pull request openucx#32 from TomAugspurger/event-notif+collection

d64ac17

Event notif+collection

nmorey mentioned this pull request Jan 13, 2022

[Q] MALLOC_HOOKS default mode description #5644

Open

ziegenbalg mentioned this pull request Dec 4, 2023

UCX not working with NAT #9526

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UCT/CONFIG: Use configuration parsing infrastructure in UCT. #32

UCT/CONFIG: Use configuration parsing infrastructure in UCT. #32

yosefe commented Nov 25, 2014

mellanox-github commented Nov 25, 2014

mike-dubman commented Nov 26, 2014

mellanox-github commented Nov 26, 2014

mike-dubman Nov 26, 2014

yosefe Nov 26, 2014

mike-dubman Nov 26, 2014

mike-dubman commented Nov 26, 2014

yosefe commented Nov 26, 2014

yosefe commented Nov 26, 2014

mellanox-github commented Nov 26, 2014

mike-dubman commented Nov 26, 2014



		ucs_config_field_t uct_iface_config_table[] = {
		{"MAX_SHORT", "128",

UCT/CONFIG: Use configuration parsing infrastructure in UCT. #32

UCT/CONFIG: Use configuration parsing infrastructure in UCT. #32

Conversation

yosefe commented Nov 25, 2014

mellanox-github commented Nov 25, 2014

mike-dubman commented Nov 26, 2014

mellanox-github commented Nov 26, 2014

mike-dubman Nov 26, 2014

Choose a reason for hiding this comment

yosefe Nov 26, 2014

Choose a reason for hiding this comment

mike-dubman Nov 26, 2014

Choose a reason for hiding this comment

mike-dubman commented Nov 26, 2014

yosefe commented Nov 26, 2014

yosefe commented Nov 26, 2014

mellanox-github commented Nov 26, 2014

mike-dubman commented Nov 26, 2014