Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement support and tests for cmap format 13 #647

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Conversation

Connum
Copy link
Contributor

@Connum Connum commented Nov 24, 2023

Description

Implements support for cmap table format 13

(also stops tracking of the dist files which was accidentally reintroduced by #503)

Motivation and Context

fixes #105

The newly added test case in the unicode test suite will show the characters as not passing because of differences in the SVG paths, but it will output the correct glyphs.

How Has This Been Tested?

npm run test and running the unicode test suite locally.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I did npm run test and all tests passed green (including code styling checks).
  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the README accordingly.
  • I have read the CONTRIBUTING document.

@Connum Connum added this to the Release 2.0.0 milestone Nov 24, 2023
@Connum Connum requested a review from yne November 24, 2023 11:50
@Connum Connum force-pushed the feature/cmap-format13 branch from d540816 to 1cdb83f Compare November 24, 2023 12:03
Copy link
Contributor

@yne yne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad the /dist/ files were merged back

@yne yne merged commit a6d0a75 into master Nov 24, 2023
1 check passed
@yne yne deleted the feature/cmap-format13 branch November 24, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide support for all cmap table formats
2 participants