Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trip Form Settings Selector Panel feedback #46

Closed
PaulIvanov opened this issue Jan 24, 2020 · 3 comments · Fixed by #48
Closed

Trip Form Settings Selector Panel feedback #46

PaulIvanov opened this issue Jan 24, 2020 · 3 comments · Fixed by #48
Assignees
Labels
bug Something isn't working HIGH High Priority

Comments

@PaulIvanov
Copy link

Hey All, just wanted to get these in front of you asap, so that they can get acknowledged when possible. Please Let me know if you need help reproducing any of the issues. Thanks!

Travel Preferences settings (ie "Optimize For/Walk Speed/Maximum Walk") with any mode of traveling is not functional. Receiving uncaught TypeError. This is visible in the OTP UI Storybook.

Trip Form/util.js line 156 is rendering an IconTag by doing a direct key lookup on line 148 which can come back null silently if the key doesnt exist.
The rendering will fail when a user tries to render that company Icon when the relevant mode is selected.
We hit this issue when one our companies had all caps as the ID instead of the normal casing.

micromobilityModes array is req'd in the supportedModes prop even though Trimet doesnt support Micromobility only modes of traveling. Without it, getBicycleOrMicromobilityModeOptions throws a `TypeError: cannot read property 'map' of null

@PaulIvanov
Copy link
Author

@fpurcell FYI

@fpurcell fpurcell added bug Something isn't working HIGH High Priority labels Jan 24, 2020
@fpurcell
Copy link
Member

Can confirm Paul's bug:
image

@binh-dam-ibigroup
Copy link
Collaborator

Thanks for pointing this out, I neglected to address that in the original code.

@fpurcell fpurcell added AS1 and removed AS1 labels Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working HIGH High Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants