Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropTypes validation errors under SettingsSelectorPanel #139

Closed
binh-dam-ibigroup opened this issue May 21, 2020 · 1 comment · Fixed by #140
Closed

PropTypes validation errors under SettingsSelectorPanel #139

binh-dam-ibigroup opened this issue May 21, 2020 · 1 comment · Fixed by #140
Assignees
@binh-dam-ibigroup

Comments

@binh-dam-ibigroup
Copy link
Collaborator

binh-dam-ibigroup commented May 21, 2020 •
edited
Loading

Original comment: ibi-group/trimet-mod-otp#260 (comment)

image
@binh-dam-ibigroup binh-dam-ibigroup self-assigned this May 21, 2020
@binh-dam-ibigroup
Copy link
Collaborator Author

@landonreed @evansiroky Any preference about dealing with this queryParams type validation?

  1. Convert the bool types in to also accommodate string,
  2. I can strip out attributes not relevant for the control,
  3. I can just remove this type and convert to PropTypes.object.

binh-dam-ibigroup added a commit to ibi-group/otp-ui that referenced this issue May 21, 2020
@binh-dam-ibigroup
fix(PropTypes): Fix component PropTypes definitions.
be55953 
fix opentripplanner#135, fix opentripplanner#139.
@binh-dam-ibigroup binh-dam-ibigroup mentioned this issue May 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@binh-dam-ibigroup binh-dam-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ui tweaks ibi-group/otp-ui
1 participant
@binh-dam-ibigroup