Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RouteViewerOverlay#leafletPath is incorrectly named (should be path according to PropTypes) #129

Closed
landonreed opened this issue May 18, 2020 · 0 comments · Fixed by #140
Closed

RouteViewerOverlay#leafletPath is incorrectly named (should be path according to PropTypes) #129

landonreed opened this issue May 18, 2020 · 0 comments · Fixed by #140
Assignees
@binh-dam-ibigroup
Labels
bug Something isn't working

Comments

@landonreed
Copy link
Member

In render function the path prop is called leafletPath:

otp-ui/packages/route-viewer-overlay/src/index.js

Line 52 in 15b1615

const { leafletPath, routeData } = this.props;

In propTypes it is called path:

otp-ui/packages/route-viewer-overlay/src/index.js

Line 91 in 15b1615

path: leafletPathType,

@landonreed landonreed added the bug Something isn't working label May 18, 2020
binh-dam-ibigroup added a commit to ibi-group/otp-ui that referenced this issue May 21, 2020
@binh-dam-ibigroup
fix: Fix various cosmetic bugs.
584f9cd 
Fix FromIcon, Accomodate long bus route names in LegDescriptionRouteShortName, Remove gray
background in LocationPicker (mobile mode), Fix RouteViewOverlayProp (breaking)

BREAKING CHANGE: RouteViewerOverlay: prop `leafletPath` renamed to `path`.

fix opentripplanner#138, fix opentripplanner#137, fix opentripplanner#136, fix opentripplanner#134, fix opentripplanner#129.
@binh-dam-ibigroup binh-dam-ibigroup mentioned this issue May 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@binh-dam-ibigroup binh-dam-ibigroup

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ui tweaks ibi-group/otp-ui
2 participants
@landonreed @binh-dam-ibigroup