Move to Vector Tiles (MapLibreGL) #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Leaflet is removed, some overlays are removed
…the entirely incorrect itinerary
…edux into vector-tiles
…-react-redux into vector-tiles pull miles changes
Merged
binh-dam-ibigroup
approved these changes
Sep 29, 2022
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
requested changes
Oct 7, 2022
| payload?.viewedRoute?.routeId === viewedRoute.routeId && | ||
| payload?.viewedRoute?.patternId === viewedRoute.patternId | ||
| ) | ||
| return |
There was a problem hiding this comment.
Not seeing braces.
| ` | ||
|
|
||
| // Compute the elevation point marker, if activeLeg and elevation profile is enabled. | ||
| let elevationPointMarker = null |
There was a problem hiding this comment.
Could you just return this variable inside the ifs and return null at the end of the function to eliminate this let?
There was a problem hiding this comment.
This code is marked as new because it was typescripted, but this is all inherited code. I'm not sure about the edge cases that we need to maintain here, so am weary of making changes to it in this PR. We could add a new issue to do this in a new PR?
| <BaseMapStyled.PopupTitle>{name}</BaseMapStyled.PopupTitle> | ||
| <BaseMapStyled.PopupRow> | ||
| <span> | ||
| <b> |
There was a problem hiding this comment.
And nested inside a span 😱
This code is inherited and will be very strongly removed once we move to the nearby view.
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
approved these changes
Oct 10, 2022
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes use of opentripplanner/otp-ui#420 to migrate to MapLibreGL. Also includes some css refreshes to match the major changes in the otp-ui updates.
Previously blocked by opentripplanner/otp-ui#436 waiting for all internal dependencies to be fully updated.
Blocked by opentripplanner/otp-ui#441 (for new gtfs-rt overlay). Tests will fail until this package is updated. The gtfs-rt overlay functionality will be hampered (bus emojis) until opentripplanner/otp-ui#441 is merged.