StreetEdges split for floating bike rentals are never unsplit after the vehicle is removed

[evansiroky]

Expected behavior

StreetEdges that were split in order to insert bike rental vertices and edges are not "unsplitted" after they are removed from the bike rental feed. This will lead to a large accumulation of unneeded StreetEdges in graphs that have many floating bike rentals.

Observed behavior

There is a TODO in the comments that describe where this should take place.

OpenTripPlanner/src/main/java/org/opentripplanner/updater/bike_rental/BikeRentalUpdater.java

Lines 182 to 195 in 3579765

	/* remove existing stations that were not present in the update */
	List<BikeRentalStation> toRemove = new ArrayList<BikeRentalStation>();
	for (Entry<BikeRentalStation, BikeRentalStationVertex> entry : verticesByStation.entrySet()) {
	BikeRentalStation station = entry.getKey();
	if (stationSet.contains(station))
	continue;
	BikeRentalStationVertex vertex = entry.getValue();
	if (graph.containsVertex(vertex)) {
	graph.removeVertexAndEdges(vertex);
	}
	toRemove.add(station);
	service.removeBikeRentalStation(station);
	// TODO: need to unsplit any streets that were split
	}

Version of OTP used (exact commit hash or JAR name)

3579765

Data sets in use (links to GTFS and OSM PBF files)

See https://maps.trimet.org/m/

Command line used to start OTP

java -jar otp-1.3.0.jar --autoScan --server --port 8888 --basePath /Users/evansiroky/workspace/portland-otp/

Router config and graph build config JSON

See https://maps.trimet.org/m/

Steps to reproduce the problem

Create a mock GBFS bike rental updater that includes a free_bike_status.json endpoint and then after the stations have been loaded for the first time, remove one of the free bikes from the feed and observed that streets that were split for the deleted free bike remain split.

[jwoyame]

This is definitely an issue for us too. Here's our street network on a fresh instance of OTP, and then after 12 days of scooter rentals 😆