This repository has been archived by the owner on Jan 26, 2024. It is now read-only.
Support copying span contexts. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@isaachier - Not a high priority, but could you take a look at this when you get the chance? |
isaachier
reviewed
May 1, 2018
mocktracer/src/mock_span_context.cpp
Outdated
| @@ -21,12 +21,20 @@ void MockSpanContext::ForeachBaggageItem( | |||
| } | |||
| } | |||
|
|
|||
| void MockSpanContext::SetData(SpanContextData& data) { | |||
| void MockSpanContext::SetData(SpanContextData& data) const { | |||
There was a problem hiding this comment.
This name is a bit confusing. Sounds like you are setting the data member named data. Maybe CopyData?
There was a problem hiding this comment.
Sure. I'll rename it.
isaachier
approved these changes
May 1, 2018
isaachier
approved these changes
May 4, 2018
isaachier
pushed a commit
to jaegertracing/jaeger-client-cpp
that referenced
this pull request
Nov 21, 2018
This was added to the opentracing API in opentracing/opentracing-cpp#56 Signed-off-by: Matt Eastman <[email protected]>
|
@rnburn Do you know when this will make it into a tagged release? It'd be really nice to be able to use this (sorry for the double ping on GitHub and gitter but wasn't sure how often you'd check them) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for copying span contexts.
Follow up from https://gitter.im/opentracing/opentracing-cpp?at=5a82810018f388e62697ab54