Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Add support for dynamic loading. #45

Merged
merged 52 commits into from
Feb 22, 2018
Merged
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
6b8bc2b
Dynamic load changes.
rnburn Nov 2, 2017
4030ec8
Remove default timestamping.
rnburn Nov 2, 2017
ed6e121
Add dynamic load functions.
rnburn Nov 5, 2017
ae66b6b
Add dynamic load code.
rnburn Nov 5, 2017
c184ee5
Merge branch 'master' of github.com:rnburn/opentracing-cpp into dlopen
rnburn Dec 5, 2017
9ad435f
Use factory interface for dynamic loading.
rnburn Dec 7, 2017
fc45b0e
Separate TracerFactory from dynamic loading.
rnburn Dec 11, 2017
920b2a0
Support specifying an error_code when dynamic load fails.
rnburn Dec 12, 2017
931b239
Allow DynamicTracingLibraryHandle to be default constructible.
rnburn Dec 13, 2017
b037065
Add documentation for make_opentracing_factory.
rnburn Dec 18, 2017
5368976
Comment dynamic_load interface.
rnburn Dec 18, 2017
3e20e42
Document tracer_factory.h
rnburn Dec 18, 2017
c41edee
Fix order in destructors.
rnburn Dec 19, 2017
16ad19b
Correct typo.
rnburn Dec 20, 2017
75b1da5
Merge branch 'master' of https://github.com/opentracing/opentracing-c…
rnburn Jan 19, 2018
4ad8a70
Remove windows stub.
rnburn Jan 19, 2018
6821cd6
Update naming convention to be more consistent.
rnburn Jan 19, 2018
ff26d65
Run clang-format.
rnburn Jan 19, 2018
c5bf3c3
Merge branch 'master' of https://github.com/opentracing/opentracing-c…
rnburn Jan 23, 2018
5955aec
Correct typo.
rnburn Jan 23, 2018
99a8f57
Add dynamic loading support to mocktracer.
rnburn Jan 23, 2018
0484533
Add tests for dynamic loading.
rnburn Jan 24, 2018
365f7ea
Run clang-format.
rnburn Jan 24, 2018
749ed80
Test for weak symbols.
rnburn Jan 25, 2018
09ed628
Run clang-format.
rnburn Jan 25, 2018
5daa522
Fix bazel build for dynamic loading support.
rnburn Jan 25, 2018
43cedf7
link 3rd party libraries in statically.
rnburn Jan 30, 2018
61f959a
Correct include guards.
rnburn Jan 31, 2018
83d97b6
Rearrange base64 code.
rnburn Jan 31, 2018
9c5c8c6
Add missing base64 code.
rnburn Jan 31, 2018
2123ae7
Include apache license.
rnburn Jan 31, 2018
4262eba
Correct typo.
rnburn Jan 31, 2018
c6dad55
Writing manual serialization code.
rnburn Feb 2, 2018
2502ce8
Add plugin library.
rnburn Feb 2, 2018
e3b1648
Add serialization for SpanData.
rnburn Feb 2, 2018
a53744b
Suppress false positive from undefined behavior sanitizer.
rnburn Feb 3, 2018
dc1e79e
Represent duration with a string.
rnburn Feb 5, 2018
152218a
Use string to represent trace/span-ids.
rnburn Feb 7, 2018
bb817a3
Remove 3rd-party json library dependency.
rnburn Feb 11, 2018
cfe28ef
Run clang-format.
rnburn Feb 11, 2018
4a30061
Add missing include.
rnburn Feb 11, 2018
9deeb34
Use strings for IDs in JSON.
rnburn Feb 12, 2018
b3717a9
Merge branch 'jsonlib' into dlopen
rnburn Feb 13, 2018
4131731
Run clang-format.
rnburn Feb 13, 2018
b9a40ff
Add dl library dependency.
rnburn Feb 13, 2018
d2297f5
Return const pointer from const member function.
rnburn Feb 14, 2018
6796a85
Remove constexpr from rvalue-ref member.
rnburn Feb 14, 2018
0d275cb
Merge branch 'expected-bug' into dlopen
rnburn Feb 14, 2018
1368b7d
Fix bazel build.
rnburn Feb 15, 2018
52d0a5c
Add example usage with mocktracer.
rnburn Feb 20, 2018
bf1189a
Add example for dynamic loading.
rnburn Feb 20, 2018
3a198e9
Add missing include.
rnburn Feb 20, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix order in destructors.
rnburn committed Dec 19, 2017
commit c41edee9322b6563022de843162d5c24c1824b77
2 changes: 1 addition & 1 deletion include/opentracing/dynamic_load.h
Original file line number Diff line number Diff line change
@@ -98,8 +98,8 @@ class DynamicTracingLibraryHandle {
}

private:
std::unique_ptr<const TracerFactory> tracer_factory_;
std::unique_ptr<DynamicLibraryHandle> dynamic_library_handle_;
std::unique_ptr<const TracerFactory> tracer_factory_;
};

// Dynamically loads a tracing library and returns a handle that can be used
5 changes: 3 additions & 2 deletions src/dynamic_load.cpp
Original file line number Diff line number Diff line change
@@ -50,7 +50,8 @@ const std::error_category& dynamic_load_error_category() {
DynamicTracingLibraryHandle::DynamicTracingLibraryHandle(
std::unique_ptr<const TracerFactory>&& tracer_factory,
std::unique_ptr<DynamicLibraryHandle>&& dynamic_library_handle) noexcept
: tracer_factory_{std::move(tracer_factory)},
dynamic_library_handle_{std::move(dynamic_library_handle)} {}
: dynamic_library_handle_{std::move(dynamic_library_handle)},
tracer_factory_{std::move(tracer_factory)} {}

END_OPENTRACING_ABI_NAMESPACE
} // namespace opentracing