Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zipkin Sampling #38

Merged
merged 2 commits into from
May 30, 2018
Merged

Zipkin Sampling #38

merged 2 commits into from
May 30, 2018

Conversation

pingles
Copy link
Contributor

@pingles pingles commented May 29, 2018

This builds upon work in rnburn/zipkin-cpp-opentracing#20 to provide probabilistic sampling when using zipkin.

  • zipkin_sample_rate configuration option added. It should be a number between 0 and 1 and determines how likely a span is to be sampled.
  • Sampling defaults to 1 (always sample) in the event of no incoming sampling decision.

@rnburn
Copy link
Collaborator

rnburn commented May 29, 2018

@pavolloffay - I was actually going to get rid of those tracer specific modules in favor using opentracing_load_tracer (See #37 )

But if you still want to merge this in, it would also need to document the option in here: https://github.com/opentracing-contrib/nginx-opentracing/blob/master/zipkin/doc/Directives.md

@pingles
Copy link
Contributor Author

pingles commented May 29, 2018

No worries, I'll add a commit with the documentation notes now.

@rnburn rnburn merged commit f877519 into opentracing-contrib:master May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants