Change span names to match Spond's span naming conventions #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My mistake! Selected the wrong upstream for this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason for this fork is to allow us to change the span names generated by this library, to use a naming convention which is more consistent with our other spans and tooling.
This changes the generated spans from using the Thrift message name as the span name, to using a fixed span name with the message name set at the "resource_name" tag. The new spans use
thrift.callon the client side, andthift.operationon the server side.This PR also incorporates the fix implemented here: jspofford@e3b54db, as discussed in this issue: #19.