Update to Kafka 3.0.0 #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <[email protected]>
|
Any chance someone can look at this? |
igorIsyutin
approved these changes
Dec 9, 2021
|
Any updates on this? |
|
Interested in this PR too. Any timescales for new version? |
moustafa-zein
approved these changes
Aug 16, 2022
|
To support Kafka 3.2.x you need to add a new methods in |
|
I was able to get this working in my fork with the Kafka 3.2.1 client, and I have tested it with Jaeger and Confluent Platform 7.2.1. The work is here: https://github.com/bashburn/java-kafka-client which I forked from this fork. Let me know, and I can try to add it here, or create a new PR if needed. |
|
Can this be merged ? |
|
I created a new PR based on my update to the libraries. It is PR #101 if we want to close this one and look at that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kafka 3.0.0 is a major release and as such it does some breaking changes such as removes some old methods which were deprecated before and adds new methods etc. This PR updates the tracing support for Kafka clients to use Kafka 3.0.
Apart form removing some removed methods and adding some new, the Embedded Kafka cluster from Spring does not support Kafka 3.0.0 yet. So I replaced it with the Embedded Kafka Cluster which is part of Apache Kafka itself. This should make the tests less dependent on Spring Kafka.
It would be great if this could get reviewed and if we can have a new release to use with Kafka 3.0.0.